add user_data trailer type#1180
Open
chenosaurus wants to merge 14 commits into
Open
Conversation
ladvoc
reviewed
Jun 19, 2026
| /// (`PTF_USER_TIMESTAMP`, `PTF_FRAME_ID`, `PTF_USER_DATA`), so individual fields | ||
| /// are `Option`. | ||
| #[derive(Debug, Clone)] | ||
| pub struct FrameMetadata { |
Contributor
There was a problem hiding this comment.
question: Could we define a helper on FrameMetadata so the user can calculate their exact max user_data length based on the other fields they have set?
Contributor
Author
There was a problem hiding this comment.
I'm not sure if FrameMetadata would be able to calculate it since all the fields get set at the same time usually. Otherwise it would need to know about the Features that were enabled on the TrackPublishOptions.
chenosaurus
force-pushed
the
dc/fm_user_data
branch
from
f5f0f1b to
87ea8d7
Compare
Contributor
ChangesetThe following package versions will be affected by this PR:
|
chenosaurus
requested review from
1egoman,
MaxHeimbrock,
alan-george-lk,
cloudwebrtc,
lukasIO,
stephen-derosa and
xianshijing-lk
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.