Skip to content

Hosted agents: first-cut adding agentName to lk commands #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shawnyang-coder wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Hosted agents: first-cut adding agentName to lk commands #896

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f70a126
first-cut adding agentName to lk commands
shawnyang-coder Apr 27, 2026
7eba8ca
Add agentName to Create/DeployAgentV2
shawnyang-coder Apr 28, 2026
a495757
Merge branch 'main' into shyang-agent-name
shawnyang-coder Apr 28, 2026
f322666
remove agent name from deploy
shawnyang-coder Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,4 +149,6 @@ require (
gopkg.in/yaml.v3 v3.0.1 // indirect
)

replace github.com/livekit/protocol => ../protocol

@shawnyang-coder shawnyang-coder Apr 28, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This replace line is only needed to get my local build to pass. I will cut a release on protocol and change to use that release before merging this pr.


tool github.com/maxbrunsfeld/counterfeiter/v6
2 changes: 0 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,6 @@ github.com/livekit/media-sdk v0.0.0-20260424094251-1e21ae1138de h1:obfPAPRvdcmCA
github.com/livekit/media-sdk v0.0.0-20260424094251-1e21ae1138de/go.mod h1:7ssWiG+U4xnbvLih9WiZbhQP6zIKMjgXdUtIE1bm/E8=
github.com/livekit/mediatransportutil v0.0.0-20251128105421-19c7a7b81c22 h1:dzCBxOGLLWVtQhL7OYK2EGN+5Q+23Mq/jfz4vQisirA=
github.com/livekit/mediatransportutil v0.0.0-20251128105421-19c7a7b81c22/go.mod h1:mSNtYzSf6iY9xM3UX42VEI+STHvMgHmrYzEHPcdhB8A=
github.com/livekit/protocol v1.45.5-0.20260423163244-347de5a2ef78 h1:kT824Ziy89MSD2/UcvgGZWZ5iiEGepDAvu9phjYHiT0=
github.com/livekit/protocol v1.45.5-0.20260423163244-347de5a2ef78/go.mod h1:e6QdWDkfot+M2nRh0eitJUS0ZLuwvKCsfiz2pWWSG3s=
github.com/livekit/psrpc v0.7.1 h1:ms37az0QTD3UXIWuUC5D/SkmKOlRMVRsI261eBWu/Vw=
github.com/livekit/psrpc v0.7.1/go.mod h1:bZ4iHFQptTkbPnB0LasvRNu/OBYXEu1NA6O5BMFo9kk=
github.com/mackerelio/go-osstat v0.2.7 h1:TCavZi10wF49bT6iQZ9eT2keGZQpC69MTDfdJej5e94=
Expand Down
19 changes: 12 additions & 7 deletions pkg/cloudagents/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,15 +77,17 @@ func New(opts ...ClientOption) (*Client, error) {
// CreateAgent creates a new agent by building from source.
func (c *Client) CreateAgent(
ctx context.Context,
agentName string,
source fs.FS,
secrets []*lkproto.AgentSecret,
regions []string,
excludeFiles []string,
buildLogStreamWriter io.Writer,
) (*lkproto.CreateAgentResponse, error) {
resp, err := c.AgentClient.CreateAgent(ctx, &lkproto.CreateAgentRequest{
Secrets: secrets,
Regions: regions,
AgentName: agentName,
Secrets: secrets,
Regions: regions,
})
if err != nil {
return nil, err
Expand All @@ -106,12 +108,14 @@ func (c *Client) CreateAgent(

func (c *Client) CreateAgentV2(
ctx context.Context,
agentName string,
secrets []*lkproto.AgentSecret,
regions []string,
) (*lkproto.CreateAgentV2Response, error) {
resp, err := c.AgentClient.CreateAgentV2(ctx, &lkproto.CreateAgentV2Request{
Secrets: secrets,
Regions: regions,
Secrets: secrets,
Regions: regions,
AgentName: agentName,
})
if err != nil {
return nil, err
Expand Down Expand Up @@ -166,10 +170,11 @@ func (c *Client) DeployAgentV2(

// RegisterAgent creates an agent record without uploading source or triggering a build.
// Use this when you intend to push a prebuilt image immediately after via GetPushTarget.
func (c *Client) RegisterAgent(ctx context.Context, secrets []*lkproto.AgentSecret, regions []string) (string, error) {
func (c *Client) RegisterAgent(ctx context.Context, agentName string, secrets []*lkproto.AgentSecret, regions []string) (string, error) {
resp, err := c.AgentClient.CreateAgent(ctx, &lkproto.CreateAgentRequest{
Secrets: secrets,
Regions: regions,
AgentName: agentName,
Secrets: secrets,
Regions: regions,
})
if err != nil {
return "", err
Expand Down
Loading