Skip to content

Commit b7face8

Browse files
committed
fix ci
1 parent 2ae0671 commit b7face8

3 files changed

Lines changed: 4 additions & 7 deletions

File tree

test/integration/docker_mac_test.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@ import (
1212
"github.com/ory/dockertest/v3"
1313
)
1414

15-
const dockerBridgeIP = "172.17.0.1"
16-
1715
var Docker *dockertest.Pool
1816

1917
func TestMain(m *testing.M) {

test/integration/docker_test.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@ import (
1111
"github.com/ory/dockertest/v3"
1212
)
1313

14-
const dockerBridgeIP = "172.17.0.1"
15-
1614
var Docker *dockertest.Pool
1715

1816
func TestMain(m *testing.M) {

test/integration/livekit_test.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,12 +74,13 @@ func runLiveKit(t testing.TB) *LiveKit {
7474
Repository: "livekit/livekit-server", Tag: "master",
7575
Cmd: []string{
7676
"--dev",
77-
// TODO: We use Docker bridge IP here instead of the host IP.
78-
// Maybe run on the host network instead? We might need it for RTP anyway.
79-
"--redis-host", dockerBridgeIP + ":" + port,
77+
// Reach host-published Redis via the Docker host gateway
78+
// (portable across runners, unlike a hardcoded bridge IP).
79+
"--redis-host", "host.docker.internal:" + port,
8080
"--bind", "0.0.0.0",
8181
},
8282
ExposedPorts: []string{"7880/tcp"},
83+
ExtraHosts: []string{"host.docker.internal:host-gateway"},
8384
})
8485
if err != nil {
8586
t.Fatal(err)

0 commit comments

Comments
 (0)