Fix AMR answer fmtp mismatch for octet-align offers (#747) - #768
Open
lixuanqun wants to merge 2 commits into
Open
Fix AMR answer fmtp mismatch for octet-align offers (#747)#768lixuanqun wants to merge 2 commits into
lixuanqun wants to merge 2 commits into
Conversation
media-sdk answers AMR/AMR-WB with rtpmap only, so an octet-aligned offer was accepted as bandwidth-efficient and produced garbled audio. Before answering, strip AMR formats we cannot support (e.g. octet-align=1); when accepting bandwidth-efficient AMR, echo RFC 4867 required fmtp params. Co-authored-by: li xuanqun <793005378@qq.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #768 +/- ##
==========================================
+ Coverage 65.25% 66.31% +1.06%
==========================================
Files 51 42 -9
Lines 6588 8114 +1526
==========================================
+ Hits 4299 5381 +1082
- Misses 1915 2234 +319
- Partials 374 499 +125 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
If filterAMROfferSDP cannot parse or re-serialize the offer, fall back to the original SDP and continue negotiation instead of aborting the call. Co-authored-by: li xuanqun <793005378@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
media-sdk answers AMR/AMR-WB with rtpmap only, so an octet-aligned offer was accepted as bandwidth-efficient and produced garbled audio.
Before answering, strip AMR formats we cannot support (e.g. octet-align=1); when accepting bandwidth-efficient AMR, echo RFC 4867 required fmtp params.