Fix border radiuses on input groups#2673
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses inconsistent border-radius styling when sm/xs input-related components are placed inline or inside input groups, by aligning flux:input and input-group affixes with the sizing/radius behavior used by other controls (notably flux:select).
Changes:
- Move
flux:inputborder radius from the base class list into the size-specific class map (rounded-lgfor default,rounded-mdforsm/xs). - Add a
sizeprop toflux:input.group.prefixandflux:input.group.suffixand apply size-specific typography + border-radius classes. - Adjust prefix/suffix base classes to support the new size-driven styling behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| stubs/resources/views/flux/input/index.blade.php | Makes input border radius size-dependent to match flux:select conventions for sm/xs. |
| stubs/resources/views/flux/input/group/prefix.blade.php | Adds size prop and size-specific radius/text handling for group prefixes. |
| stubs/resources/views/flux/input/group/suffix.blade.php | Adds size prop and size-specific radius/text handling for group suffixes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
joshhanley
left a comment
There was a problem hiding this comment.
@mauritskorse thanks for the PR! Looks good to me. I made a few changes, which Copilot had flagged and also did a review of Flux and Flux Pro inputs side by side. I've submitted a PR to Flux Pro to update those too.
Before
After
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Reviewed — this brings inputs in line with the button/select radius convention ( Two small follow-ups we may want: |
The scenario
When placing varous small or extra small sized input components inline or within a input group, it shows that their border radius are not consistent.
The problem
On
smandxssized components we have these two different implementations:There is a
rounded-lgon:flux:inputflux:input.group.prefixflux:input.group.suffixflux:autocomplete(pro)flux:colorpicker(pro)And a
rounded-mdon:flux:select(partially pro)flux:datepicker(pro)flux:pillbox(pro) --> only forsmsized;xssized does not existThe solution
This PR makes the border radiuses consistent with
flux:selectandflux:colorpickeron the free componentsflux:input,flux:input.group.prefixandflux:input.group.suffix. To do this,group.prefixandgroup.suffixneedsizeproperty support.Fixes #2672