Skip to content

Fix border radiuses on input groups#2673

Open
mauritskorse wants to merge 4 commits into
livewire:mainfrom
mauritskorse:fix/border-radius-consistency
Open

Fix border radiuses on input groups#2673
mauritskorse wants to merge 4 commits into
livewire:mainfrom
mauritskorse:fix/border-radius-consistency

Conversation

@mauritskorse

Copy link
Copy Markdown

The scenario

When placing varous small or extra small sized input components inline or within a input group, it shows that their border radius are not consistent.

The problem

On sm and xs sized components we have these two different implementations:

There is a rounded-lg on:

  • flux:input
  • flux:input.group.prefix
  • flux:input.group.suffix
  • flux:autocomplete (pro)
  • flux:colorpicker (pro)

And a rounded-md on:

  • flux:select (partially pro)
  • flux:datepicker (pro)
  • flux:pillbox (pro) --> only for sm sized; xs sized does not exist

The solution

This PR makes the border radiuses consistent with flux:select and flux:colorpicker on the free components flux:input,flux:input.group.prefix and flux:input.group.suffix. To do this, group.prefix and group.suffix need size property support.

Fixes #2672

Copilot AI review requested due to automatic review settings June 30, 2026 20:36

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses inconsistent border-radius styling when sm/xs input-related components are placed inline or inside input groups, by aligning flux:input and input-group affixes with the sizing/radius behavior used by other controls (notably flux:select).

Changes:

  • Move flux:input border radius from the base class list into the size-specific class map (rounded-lg for default, rounded-md for sm/xs).
  • Add a size prop to flux:input.group.prefix and flux:input.group.suffix and apply size-specific typography + border-radius classes.
  • Adjust prefix/suffix base classes to support the new size-driven styling behavior.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
stubs/resources/views/flux/input/index.blade.php Makes input border radius size-dependent to match flux:select conventions for sm/xs.
stubs/resources/views/flux/input/group/prefix.blade.php Adds size prop and size-specific radius/text handling for group prefixes.
stubs/resources/views/flux/input/group/suffix.blade.php Adds size prop and size-specific radius/text handling for group suffixes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread stubs/resources/views/flux/input/group/prefix.blade.php Outdated
Comment thread stubs/resources/views/flux/input/group/suffix.blade.php Outdated
Comment thread stubs/resources/views/flux/input/group/suffix.blade.php Outdated
@joshhanley joshhanley changed the title Fix/border radius consistency Fix border radiuses on input groups Jun 30, 2026

@joshhanley joshhanley left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mauritskorse thanks for the PR! Looks good to me. I made a few changes, which Copilot had flagged and also did a review of Flux and Flux Pro inputs side by side. I've submitted a PR to Flux Pro to update those too.


Before

Image

After

Image

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@calebporzio

Copy link
Copy Markdown
Contributor

Reviewed — this brings inputs in line with the button/select radius convention (rounded-lg default, rounded-md at sm/xs), and the logical rounded-s/e classes keep RTL happy. The prefix/suffix text-size change (text-smtext-base sm:text-sm) now matches the input's own font size on mobile, so that's a fix too. Ready to merge from my end.

Two small follow-ups we may want: flux:input.group.affix still has flat text-sm with no size prop, so a mid-group affix won't match sm/xs sizing; and since size isn't inherited, folks have to repeat it on the prefix/suffix — could consider a size prop on flux:input.group + @aware later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Border radius on small input components not consistent

4 participants