fix: skip non-active gateway helm repos in _add_helm_repos()#1438
Open
Jwrede wants to merge 1 commit into
Open
fix: skip non-active gateway helm repos in _add_helm_repos()#1438Jwrede wants to merge 1 commit into
Jwrede wants to merge 1 commit into
Conversation
_add_helm_repos() iterated over all helmRepositories entries without checking gateway.className, so the Istio repo was always added even when the active gateway was agentgateway. Gate gateway-specific repo keys (istio, agentgateway) on the active className, matching the pattern already used by _install_gateway_provider(). Fixes llm-d#1394 Signed-off-by: Jonathan Wrede <wrede.jonathan00@gmail.com>
Jwrede
requested review from
Vezio,
achandrasekar,
kalantar,
maugustosilva,
mengmeiye and
namasl
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_add_helm_repos()iterates over allhelmRepositoriesentries without checkinggateway.className, so the Istio Helm repo is always added even when the active gateway isagentgateway(or any other non-Istio gateway).This adds a gateway-class filter for known gateway-specific repo keys (
istio,agentgateway), matching the pattern already used by_install_gateway_provider()which correctly gates ongateway.className.Fixes #1394
Changes
_GATEWAY_REPO_KEYSclass-level constant with the set of gateway-specific repo keysgateway.classNamefromplan_configat the start of_add_helm_repos()_GATEWAY_REPO_KEYSbut does not match the active gateway classTest plan
llmdbenchmark standupwithgateway.className: agentgatewayand verify Istio repo is not addedgateway.className: istioand verify Istio repo is added normallygateway.className: epponlyand verify both gateway repos are skipped