Support configurable listener port for the per-stack Gateway#1439
Open
yardenmaymon-td wants to merge 1 commit into
Open
Support configurable listener port for the per-stack Gateway#1439yardenmaymon-td wants to merge 1 commit into
yardenmaymon-td wants to merge 1 commit into
Conversation
yardenmaymon-td
requested review from
Vezio,
achandrasekar,
kalantar,
maugustosilva,
mengmeiye and
namasl
as code owners
Render gateway.listenerPort (when set) into the listeners block for the gke, agentgateway, and istio gateway classes. data-science-gateway-class pins the listener to 443 HTTPS+TLS, so a new `raise` jinja global makes the template fail loudly if listenerPort is set there. Default behaviour (no listenerPort) is unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Yarden Maymon <yarden.maymon@twodelta.com>
yardenmaymon-td
force-pushed
the
gateway-listener-port
branch
from
c0a62d0 to
03ec046
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an optional
gateway.listenerPortconfig that renders a custom HTTP listener into the per-stack Gateway resource (11_infra.yaml.j2).gateway.listenerPortis set, a default HTTP listener on that port is rendered into thelistenersblock. When unset, the block is omitted and behaviour is unchanged.listenerPortis unsupported there. A newraisejinja global makes the template fail loudly with a clear message instead of silently producing an invalid Gateway.Why
Lets scenarios expose the Gateway on a non-default port without editing templates, while keeping the fixed-port classes safe.
Notes
listenerPort) is unchanged for every gateway class.0) is treated as unset.defaults.yaml.Testing
New
tests/test_gateway_listener_port.py(16 tests) renders the real template for every gateway class, with and withoutlistenerPort, asserts the data-science guard raises, and covers theraiseglobal. Full suite: 288 passed, 4 skipped.🤖 Generated with Claude Code