Skip to content
This repository was archived by the owner on Oct 15, 2025. It is now read-only.

using imagepullsecrts for epp/pd secrets#25

Merged
Gregory-Pereira merged 4 commits into
llm-d:mainfrom
Gregory-Pereira:update-ms-rbac-v2-attempt-4
May 6, 2025
Merged

using imagepullsecrts for epp/pd secrets#25
Gregory-Pereira merged 4 commits into
llm-d:mainfrom
Gregory-Pereira:update-ms-rbac-v2-attempt-4

Conversation

@Gregory-Pereira
Copy link
Copy Markdown
Member

cc @nerdalert @cfchase

This would fix your demo issues. Leaving it to you to merge and re-verify or hold

@Gregory-Pereira
Copy link
Copy Markdown
Member Author

/hold till after demo for stability

@Gregory-Pereira Gregory-Pereira added the hold Hold until future date or event label May 6, 2025
Comment thread charts/llm-d/templates/modelservice/_helpers.tpl Outdated
tumido
tumido previously approved these changes May 6, 2025
Copy link
Copy Markdown
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@Gregory-Pereira Gregory-Pereira removed the hold Hold until future date or event label May 6, 2025
Gregory-Pereira and others added 3 commits May 6, 2025 07:55
Signed-off-by: greg pereira <grpereir@redhat.com>
non global pull-secrets as well

Co-authored-by: Tom Coufal <7453394+tumido@users.noreply.github.com>
Signed-off-by: greg pereira <grpereir@redhat.com>
Signed-off-by: greg pereira <grpereir@redhat.com>
@Gregory-Pereira Gregory-Pereira merged commit b198297 into llm-d:main May 6, 2025
3 of 4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants