Skip to content

llmd router metrics collector plugin.#215

Open
Mohammad-nassar10 wants to merge 5 commits into
llm-d:mainfrom
Mohammad-nassar10:kv-metrics-collector
Open

llmd router metrics collector plugin.#215
Mohammad-nassar10 wants to merge 5 commits into
llm-d:mainfrom
Mohammad-nassar10:kv-metrics-collector

Conversation

@Mohammad-nassar10

@Mohammad-nassar10 Mohammad-nassar10 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
Adds the llmd-router-metrics-collector datalayer plugin, which polls each model's pool-aggregated Prometheus endpoint on a configurable interval and writes a datalayer.RouterMetrics attribute per model. This gives downstream scorer plugins white-box access to KV-cache pressure, queue depth, and running request counts.

Which issue(s) this PR fixes:

Fixes #235.

Release note (write NONE if no user-facing change):

NONE

Signed-off-by: Mohammad <mohammad.nassar@ibm.com>
@Mohammad-nassar10
Mohammad-nassar10 marked this pull request as draft July 6, 2026 14:18
@github-actions github-actions Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 6, 2026
@ronenkat

ronenkat commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

can you rename the plugin to reflect that it is a llm-d router metrics collector?

@ronenkat ronenkat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mohammad-nassar10 please create an issue describing the motivation for the collector (i.e., black-box vs. white-box understanding of the inference pool)

Comment thread pkg/framework/plugins/datalayer/kvcachecollector/plugin.go Outdated
Comment thread pkg/framework/plugins/datalayer/kvcachecollector/plugin.go Outdated
Signed-off-by: Mohammad <mohammad.nassar@ibm.com>
@github-actions github-actions Bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 12, 2026
Mohammad-nassar10 and others added 2 commits July 12, 2026 19:20
Signed-off-by: Mohammad-nassar10 <79787844+Mohammad-nassar10@users.noreply.github.com>
Signed-off-by: Mohammad <mohammad.nassar@ibm.com>
@Mohammad-nassar10
Mohammad-nassar10 marked this pull request as ready for review July 12, 2026 16:28
@github-actions github-actions Bot added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Jul 12, 2026
@Mohammad-nassar10 Mohammad-nassar10 changed the title Kv cache collector plugin. llmd router metrics collector plugin. Jul 13, 2026
@github-actions github-actions Bot added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Jul 13, 2026
Signed-off-by: Mohammad-nassar10 <79787844+Mohammad-nassar10@users.noreply.github.com>
parameters:
interval: "30s"
timeout: "5s"
utilizationMetric: "vllm:kv_cache_usage_perc"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't the default be something like llm_d_epp_average_kv_cache_utilization ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

llmd-router-metrics-collector to collect metrics from inference pools

2 participants