Skip to content

[Feature] RequestCostMetadataExtractor registration and config#238

Merged
github-actions[bot] merged 9 commits into
llm-d:mainfrom
davidbreitgand:costguard-requestcostmetadata-extractor-config
Jul 14, 2026
Merged

[Feature] RequestCostMetadataExtractor registration and config#238
github-actions[bot] merged 9 commits into
llm-d:mainfrom
davidbreitgand:costguard-requestcostmetadata-extractor-config

Conversation

@davidbreitgand

@davidbreitgand davidbreitgand commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Adds registration code for RequestCostMetadataExtractor plugin
  • Adds README.md for the plugin (including an example of configuration)

To connect the RequestCostMetadataExtractor plugin with the rest of the plugin system.

These topics were intentionally left out of scope for PR #232.
Need to complete the implementation.

Which issue(s) this PR fixes:

Fixes #231

Release note (write NONE if no user-facing change):

The new feature should be surfaced in the user guide.

…ibution

Signed-off-by: David Breitgand <davidbreitgand@users.noreply.github.com>
Signed-off-by: David Breitgand <davidbreitgand@users.noreply.github.com>
Signed-off-by: David Breitgand <davidbreitgand@users.noreply.github.com>
…s per reviewer's suggestion

Signed-off-by: David Breitgand <davidbreitgand@users.noreply.github.com>
…tion

Signed-off-by: David Breitgand <davidbreitgand@users.noreply.github.com>
…r suggestion

Signed-off-by: David Breitgand <davidbreitgand@users.noreply.github.com>
Signed-off-by: David Breitgand <davidbreitgand@users.noreply.github.com>
…or pointers instead of bool flags

Signed-off-by: David Breitgand <davidbreitgand@users.noreply.github.com>
@github-actions github-actions Bot added kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Jul 13, 2026
@davidbreitgand

Copy link
Copy Markdown
Contributor Author

/cc @shmuelk

@github-actions
github-actions Bot requested a review from shmuelk July 13, 2026 11:58
@davidbreitgand

Copy link
Copy Markdown
Contributor Author

@shmuelk , a review will be highly appreciated. Thanks a lot in advance.

@davidbreitgand
davidbreitgand force-pushed the costguard-requestcostmetadata-extractor-config branch from 703bb35 to 8bfa0f7 Compare July 13, 2026 14:42
…l. config example)

Signed-off-by: David Breitgand <davidbreitgand@users.noreply.github.com>

Signed-off-by: David Breitgand <davidbreitgand@users.noreply.github.com>

Signed-off-by: David Breitgand <davidbreitgand@users.noreply.github.com>

Signed-off-by: David Breitgand <davidbreitgand@users.noreply.github.com>

Signed-off-by: David Breitgand <davidbreitgand@users.noreply.github.com>
@davidbreitgand
davidbreitgand force-pushed the costguard-requestcostmetadata-extractor-config branch from 8bfa0f7 to 2c5551c Compare July 13, 2026 14:48
@shmuelk

shmuelk commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

/lgtm
/approve

@github-actions github-actions Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2026
@github-actions
github-actions Bot merged commit cece268 into llm-d:main Jul 14, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Add RequestCostMetadataExtractor plugin

2 participants