Skip to content

Move group configuration Modelconfig collector group conf#241

Merged
github-actions[bot] merged 5 commits into
llm-d:mainfrom
ronenkat:modelconfig-collector-group-conf
Jul 16, 2026
Merged

Move group configuration Modelconfig collector group conf#241
github-actions[bot] merged 5 commits into
llm-d:mainfrom
ronenkat:modelconfig-collector-group-conf

Conversation

@ronenkat

@ronenkat ronenkat commented Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What type of PR is this?
/kind cleanup
/kind feature

What this PR does / why we need it:

  1. Move model group configuration to model-config-datasource per issue [Feature] Make model-group filter groups dynamic via model-config-datasource ConfigMap #240
  2. Move configuration tests to model-config-datasource test code.
  3. Refactor model-config-datasource test code to reduce wait time for updating the configuration
  4. Update readme to reflect changes.

Which issue(s) this PR fixes:
Fixes #240

Release note (write NONE if no user-facing change):

NONE

ronenkat added 2 commits July 15, 2026 09:35
@ronenkat
move config to modelconfigcollector
c540352 
Signed-off-by: ronenkat <16743404+ronenkat@users.noreply.github.com>
@ronenkat
updated tests
54489e5 
Signed-off-by: ronenkat <16743404+ronenkat@users.noreply.github.com>
@github-actions github-actions Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. and removed kind/feature Categorizes issue or PR as related to a new feature. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jul 15, 2026
@ronenkat
ronenkat marked this pull request as ready for review July 15, 2026 10:56
@github-actions github-actions Bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. labels Jul 15, 2026
shmuelk
shmuelk reviewed Jul 15, 2026
View reviewed changes
Comment thread pkg/framework/interface/datalayer/modelgroups/modelgroups.go
shmuelk
shmuelk reviewed Jul 15, 2026
View reviewed changes
Comment thread pkg/framework/plugins/datalayer/modelconfigcollector/plugin.go
shmuelk
shmuelk reviewed Jul 15, 2026
View reviewed changes
Comment thread pkg/framework/plugins/datalayer/modelconfigcollector/plugin.go
Mohammad-nassar10
Mohammad-nassar10 reviewed Jul 15, 2026
View reviewed changes
Comment thread pkg/framework/plugins/datalayer/modelconfigcollector/plugin.go
Comment thread pkg/framework/plugins/modelselector/filter/modelgroup/filter_test.go Outdated
Comment thread pkg/framework/plugins/datalayer/modelconfigcollector/plugin_test.go Outdated
Comment thread pkg/framework/plugins/modelselector/filter/modelgroup/README.md Outdated
Comment thread pkg/framework/plugins/modelselector/filter/modelgroup/README.md Outdated
shmuelk
shmuelk reviewed Jul 15, 2026
View reviewed changes
Comment thread pkg/framework/plugins/datalayer/modelconfigcollector/plugin_test.go Outdated
ronenkat added 3 commits July 16, 2026 07:42
@ronenkat
Merge remote-tracking branch 'upstream/main' into modelconfig-collect…
0e95560 
…or-group-conf
@ronenkat
address review
6c1836d 
Signed-off-by: ronenkat <16743404+ronenkat@users.noreply.github.com>
@ronenkat
revert changes to requestcostmetadata/plugin_test.go
09d2fca 
Signed-off-by: ronenkat <16743404+ronenkat@users.noreply.github.com>
@shmuelk

shmuelk commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

/lgtm
/approve

@github-actions github-actions Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 16, 2026
@github-actions
github-actions Bot merged commit e6267d7 into llm-d:main Jul 16, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shmuelk shmuelk shmuelk left review comments
@github-actions github-actions[bot] github-actions[bot] approved these changes
+1 more reviewer
@Mohammad-nassar10 Mohammad-nassar10 Mohammad-nassar10 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature] Make model-group filter groups dynamic via model-config-datasource ConfigMap

3 participants

@ronenkat @shmuelk @Mohammad-nassar10