Emit datalayer response event on the streaming path#242
Merged
nirrozenbaum merged 2 commits intoJul 15, 2026
Conversation
Signed-off-by: Arad Halevy <arad.halevy@ibm.com>
Signed-off-by: Arad Halevy <arad.halevy@ibm.com>
github-actions
Bot
added
kind/bug
Contributor
Author
|
/cc @nirrozenbaum |
Collaborator
|
/lgtm Thanks! |
github-actions
Bot
added
the
lgtm
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR moves the
Notifycall to theEndOfStreamblock inServer.Process, so it fires exactly once per request on both the buffered and streaming paths.Which issue(s) this PR fixes:
Fixes #233
Release note (write
NONEif no user-facing change):