increase code coverage

Author: lloricode

src/DataTransferObjects/Checkout/CheckoutDto.php

@@ -56,10 +56,6 @@ public function __construct(
 
     public static function fromArray(array $data): static
     {
-        $metadata = isset($data['metadata'])
-            ? new MetaDataDto(...$data['metadata'])
-            : null;
-
         $totalAmount = null;
         if (isset($data['totalAmount'])) {
             $ta = $data['totalAmount'];
@@ -99,14 +95,6 @@ public static function fromArray(array $data): static
             );
         }
 
-        $redirectUrl = isset($data['redirectUrl'])
-            ? new RedirectUrlDto(...$data['redirectUrl'])
-            : null;
-
-        $merchant = isset($data['merchant'])
-            ? new MerchantDto(...$data['merchant'])
-            : null;
-
         $paymentDetails = null;
         if (isset($data['paymentDetails'])) {
             $pd = $data['paymentDetails'];
@@ -165,11 +153,11 @@ public static function fromArray(array $data): static
             totalAmount: $totalAmount ?? new TotalAmountDto,
             buyer: $buyer,
             items: $data['items'] ?? [],
-            redirectUrl: $redirectUrl,
+            redirectUrl: new RedirectUrlDto(...($data['redirectUrl'] ?? [])),
             status: $data['status'] ?? null,
             paymentStatus: $data['paymentStatus'] ?? null,
             requestReferenceNumber: $data['requestReferenceNumber'] ?? null,
-            metadata: $metadata,
+            metadata: new MetaDataDto(...($data['metadata'] ?? [])),
             receiptNumber: $data['receiptNumber'] ?? null,
             createdAt: $data['createdAt'] ?? null,
             updatedAt: $data['updatedAt'] ?? null,
@@ -178,7 +166,7 @@ public static function fromArray(array $data): static
             refundedAmount: $data['refundedAmount'] ?? 0,
             canPayPal: $data['canPayPal'] ?? null,
             paymentScheme: $data['paymentScheme'] ?? null,
-            merchant: $merchant,
+            merchant: new MerchantDto(...($data['merchant'] ?? [])),
             paymentDetails: $paymentDetails,
             transactionReferenceNumber: $data['transactionReferenceNumber'] ?? null,
         );

tests/Requests/Checkout/GetCheckoutRequestTest.php

@@ -164,7 +164,14 @@
         "failure": "https:\/\/staging-api2",
         "cancel": "https:\/\/staging-api3"
     },
-    "transactionReferenceNumber": "xxx"
+    "transactionReferenceNumber": "xxx","metadata":{
+        "mci":"mci",
+        "mco":"mco",
+        "mpc":"mpc",
+        "mst":"mst",
+        "smi":"smi",
+        "smn":"smn"
+    }
 }';
 
     MockClient::global([