[lldb][windows] fix build issue#195089
Merged
felipepiovezan merged 1 commit intoApr 30, 2026
Merged
Conversation
|
@llvm/pr-subscribers-lldb Author: Charles Zablit (charles-zablit) ChangesFix a build issue on Windows introduced by #192964. Full diff: https://github.com/llvm/llvm-project/pull/195089.diff 1 Files Affected:
diff --git a/lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp b/lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp
index 460225ea455e3..c41547a2c0961 100644
--- a/lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp
+++ b/lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp
@@ -415,7 +415,7 @@ void ProcessWindows::RefreshStateAfterStop() {
// If we're at a BreakpointSite, mark this as an Unexecuted Breakpoint.
// We'll clear that state if we've actually executed the breakpoint.
BreakpointSiteSP site(GetBreakpointSiteList().FindByAddress(pc));
- if (site && site->IsEnabled())
+ if (site && IsBreakpointSiteEnabled(*site))
stop_thread->SetThreadStoppedAtUnexecutedBP(pc);
switch (active_exception->GetExceptionCode()) {
|
felipepiovezan
approved these changes
Apr 30, 2026
felipepiovezan
left a comment
felipepiovezan
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fix!
weliveindetail
approved these changes
Apr 30, 2026
weliveindetail
left a comment
weliveindetail
left a comment
Member
There was a problem hiding this comment.
Fixes the issue for me locally 👍
medismailben
pushed a commit
to medismailben/llvm-project
that referenced
this pull request
May 1, 2026
Fix a build issue on Windows introduced by llvm#192964. (cherry picked from commit abc0093)
enferex
pushed a commit
to enferex/llvm-project
that referenced
this pull request
May 5, 2026
Fix a build issue on Windows introduced by llvm#192964.
moar55
pushed a commit
to moar55/llvm-project
that referenced
this pull request
May 12, 2026
Fix a build issue on Windows introduced by llvm#192964.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a build issue on Windows introduced by #192964.