Skip to content

[lldb][test] Fix duplicate error messages in expect_expr/var_path #202310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Teemperor wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[lldb][test] Fix duplicate error messages in expect_expr/var_path #202310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lldb/packages/Python/lldbsuite/test/lldbtest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ def __init__(
self.children = children
self.dereference = dereference

def check_value(self, test_base, val, error_msg=None):
def check_value(self, test_base, val, error_msg=""):
"""
Checks that the given value matches the currently set properties
of this ValueCheck. If a match failed, the given TestBase will
Expand Down Expand Up @@ -335,7 +335,7 @@ def check_value(self, test_base, val, error_msg=None):
if self.dereference is not None:
self.dereference.check_value(test_base, val.Dereference(), error_msg)

def check_value_children(self, test_base, val, error_msg=None):
def check_value_children(self, test_base, val, error_msg=""):
"""
Checks that the children of a SBValue match a certain structure and
have certain properties.
Expand Down Expand Up @@ -2923,7 +2923,7 @@ def expect_expr(
summary=result_summary,
children=result_children,
)
value_check.check_value(self, eval_result, str(eval_result))
value_check.check_value(self, eval_result)
return eval_result

def expect_var_path(
Expand All @@ -2950,7 +2950,7 @@ def expect_var_path(
value_check = ValueCheck(
type=type, value=value, summary=summary, children=children
)
value_check.check_value(self, eval_result, str(eval_result))
value_check.check_value(self, eval_result)
return eval_result

"""Assert that an lldb.SBError is in the "success" state."""
Expand Down
Loading