Skip to content

[clang][bytecode] Check Ptr primtype in Store op #202314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tbaederr wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −0
Open

[clang][bytecode] Check Ptr primtype in Store op #202314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions clang/lib/AST/ByteCode/Interp.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2191,6 +2191,8 @@ bool Store(InterpState &S, CodePtr OpPC) {
const Pointer &Ptr = S.Stk.peek<Pointer>();
if (!CheckStore(S, OpPC, Ptr))
return false;
if (!Ptr.canDeref(Name))
return false;
if (Ptr.canBeInitialized())
Ptr.initialize();
Ptr.deref<T>() = Value;
Expand All @@ -2203,6 +2205,8 @@ bool StorePop(InterpState &S, CodePtr OpPC) {
const Pointer &Ptr = S.Stk.pop<Pointer>();
if (!CheckStore(S, OpPC, Ptr))
return false;
if (!Ptr.canDeref(Name))
return false;
if (Ptr.canBeInitialized())
Ptr.initialize();
Ptr.deref<T>() = Value;
Expand Down
9 changes: 9 additions & 0 deletions clang/test/AST/ByteCode/cxx20.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1404,3 +1404,12 @@ namespace InvalidOMPRequiredSimdAlign {
typedef decltype(sizeof(int)) T;
constexpr T foo(T x) { return __builtin_omp_required_simd_align * 42; } // both-error {{indirection requires pointer operand}}
}

namespace StoreCannotDeref {
constexpr void foo() { // both-error {{never produces a constant expression}}
int l = 10;
int *n = &l;
int *m = (int *)&n; // both-note {{cast that performs the conversions of a reinterpret_cast}}
*m = 42;
}
}
Loading