Skip to content

[libc++][span][test] Various cleanups for <span> tests #202319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eiytoq wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[libc++][span][test] Various cleanups for <span> tests #202319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e06321e
test
eiytoq Jun 5, 2026
8178a53
ci
eiytoq Jun 8, 2026
c8b4060
fix
eiytoq Jun 8, 2026
4ba3864
fix
eiytoq Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions libcxx/test/std/containers/views/views.span/enable_borrowed_range.compile.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,22 +6,21 @@
//
//===----------------------------------------------------------------------===//

// UNSUPPORTED: c++03, c++11, c++14, c++17
// REQUIRES: std-at-least-c++20

// <span>

// template<class ElementType, size_t Extent>
// inline constexpr bool ranges::enable_borrowed_range<
// span<ElementType, Extent>> = true;
// constexpr bool ranges::enable_borrowed_range<span<ElementType, Extent>> = true;

#include <span>

#include "test_macros.h"

void test() {
static_assert(std::ranges::enable_borrowed_range<std::span<int, 0> >);
static_assert(std::ranges::enable_borrowed_range<std::span<int, 42> >);
static_assert(std::ranges::enable_borrowed_range<std::span<int, std::dynamic_extent> >);
static_assert(std::ranges::enable_borrowed_range<std::span<int, 0>>);
static_assert(std::ranges::enable_borrowed_range<std::span<int, 42>>);
static_assert(std::ranges::enable_borrowed_range<std::span<int, std::dynamic_extent>>);
static_assert(!std::ranges::enable_borrowed_range<std::span<int, 42>&>);
static_assert(!std::ranges::enable_borrowed_range<std::span<int, 42> const>);
}
4 changes: 2 additions & 2 deletions libcxx/test/std/containers/views/views.span/range_concept_conformance.compile.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
//
//===----------------------------------------------------------------------===//

// UNSUPPORTED: c++03, c++11, c++14, c++17
// REQUIRES: std-at-least-c++20

// span
// <span>

#include <span>

Expand Down
77 changes: 38 additions & 39 deletions libcxx/test/std/containers/views/views.span/span.cons/array.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,16 @@
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
// UNSUPPORTED: c++03, c++11, c++14, c++17

// REQUIRES: std-at-least-c++20

// <span>

// template<size_t N>
// constexpr span(element_type (&arr)[N]) noexcept;
// template<size_t N> constexpr span(type_identity_t<element_type> (&arr)[N]) noexcept;
//
// Remarks: These constructors shall not participate in overload resolution unless:
// Constraints: Let U be remove_pointer_t<decltype(std::data(arr))>.
// - extent == dynamic_extent || N == extent is true, and
// - remove_pointer_t<decltype(data(arr))>(*)[] is convertible to ElementType(*)[].
//
// - is_convertible_v<U(*)[], element_type(*)[]> is true.

#include <cassert>
#include <span>
Expand All @@ -30,40 +29,40 @@ void checkCV() {
volatile int varr[] = {7, 8, 9};
const volatile int cvarr[] = {1, 3, 5};

// Types the same (dynamic sized)
// Types the same (dynamic sized)
{
std::span< int> s1{arr}; // a span< int> pointing at int.
std::span<const int> s2{carr}; // a span<const int> pointing at const int.
std::span< volatile int> s3{varr}; // a span< volatile int> pointing at volatile int.
std::span<int> s1{arr}; // a span<int> pointing at int.
std::span<const int> s2{carr}; // a span<const int> pointing at const int.
std::span<volatile int> s3{varr}; // a span<volatile int> pointing at volatile int.
std::span<const volatile int> s4{cvarr}; // a span<const volatile int> pointing at const volatile int.
assert(s1.size() + s2.size() + s3.size() + s4.size() == 12);
}

// Types the same (static sized)
// Types the same (static sized)
{
std::span< int, 3> s1{arr}; // a span< int> pointing at int.
std::span<const int, 3> s2{carr}; // a span<const int> pointing at const int.
std::span< volatile int, 3> s3{varr}; // a span< volatile int> pointing at volatile int.
std::span<int, 3> s1{arr}; // a span<int> pointing at int.
std::span<const int, 3> s2{carr}; // a span<const int> pointing at const int.
std::span<volatile int, 3> s3{varr}; // a span<volatile int> pointing at volatile int.
std::span<const volatile int, 3> s4{cvarr}; // a span<const volatile int> pointing at const volatile int.
assert(s1.size() + s2.size() + s3.size() + s4.size() == 12);
}

// types different (dynamic sized)
// types different (dynamic sized)
{
std::span<const int> s1{arr}; // a span<const int> pointing at int.
std::span< volatile int> s2{arr}; // a span< volatile int> pointing at int.
std::span< volatile int> s3{arr}; // a span< volatile int> pointing at const int.
std::span<const int> s1{arr}; // a span<const int> pointing at int.
std::span<volatile int> s2{arr}; // a span<volatile int> pointing at int.
std::span<volatile int> s3{arr}; // a span<volatile int> pointing at const int.
std::span<const volatile int> s4{arr}; // a span<const volatile int> pointing at int.
std::span<const volatile int> s5{carr}; // a span<const volatile int> pointing at const int.
std::span<const volatile int> s6{varr}; // a span<const volatile int> pointing at volatile int.
assert(s1.size() + s2.size() + s3.size() + s4.size() + s5.size() + s6.size() == 18);
}

// types different (static sized)
// types different (static sized)
{
std::span<const int, 3> s1{arr}; // a span<const int> pointing at int.
std::span< volatile int, 3> s2{arr}; // a span< volatile int> pointing at int.
std::span< volatile int, 3> s3{arr}; // a span< volatile int> pointing at const int.
std::span<const int, 3> s1{arr}; // a span<const int> pointing at int.
std::span<volatile int, 3> s2{arr}; // a span<volatile int> pointing at int.
std::span<volatile int, 3> s3{arr}; // a span<volatile int> pointing at const int.
std::span<const volatile int, 3> s4{arr}; // a span<const volatile int> pointing at int.
std::span<const volatile int, 3> s5{carr}; // a span<const volatile int> pointing at const int.
std::span<const volatile int, 3> s6{varr}; // a span<const volatile int> pointing at volatile int.
Expand Down Expand Up @@ -116,39 +115,39 @@ int main(int, char**) {

// Size wrong
{
static_assert(!std::is_constructible<std::span<int, 2>, int(&)[3]>::value, "");
static_assert(!std::is_constructible_v<std::span<int, 2>, int (&)[3]>);
}

// Type wrong
{
static_assert(!std::is_constructible<std::span<float>, int(&)[3]>::value, "");
static_assert(!std::is_constructible<std::span<float, 3>, int(&)[3]>::value, "");
static_assert(!std::is_constructible_v<std::span<float>, int (&)[3]>);
static_assert(!std::is_constructible_v<std::span<float, 3>, int (&)[3]>);
}

// CV wrong (dynamically sized)
{
static_assert(!std::is_constructible<std::span<int>, const int(&)[3]>::value, "");
static_assert(!std::is_constructible<std::span<int>, volatile int(&)[3]>::value, "");
static_assert(!std::is_constructible<std::span<int>, const volatile int(&)[3]>::value, "");
static_assert(!std::is_constructible_v<std::span<int>, const int (&)[3]>);
static_assert(!std::is_constructible_v<std::span<int>, volatile int (&)[3]>);
static_assert(!std::is_constructible_v<std::span<int>, const volatile int (&)[3]>);

static_assert(!std::is_constructible<std::span<const int>, volatile int(&)[3]>::value, "");
static_assert(!std::is_constructible<std::span<const int>, const volatile int(&)[3]>::value, "");
static_assert(!std::is_constructible_v<std::span<const int>, volatile int (&)[3]>);
static_assert(!std::is_constructible_v<std::span<const int>, const volatile int (&)[3]>);

static_assert(!std::is_constructible<std::span<volatile int>, const int(&)[3]>::value, "");
static_assert(!std::is_constructible<std::span<volatile int>, const volatile int(&)[3]>::value, "");
static_assert(!std::is_constructible_v<std::span<volatile int>, const int (&)[3]>);
static_assert(!std::is_constructible_v<std::span<volatile int>, const volatile int (&)[3]>);
}

// CV wrong (statically sized)
{
static_assert(!std::is_constructible<std::span<int, 3>, const int(&)[3]>::value, "");
static_assert(!std::is_constructible<std::span<int, 3>, volatile int(&)[3]>::value, "");
static_assert(!std::is_constructible<std::span<int, 3>, const volatile int(&)[3]>::value, "");
static_assert(!std::is_constructible_v<std::span<int, 3>, const int (&)[3]>);
static_assert(!std::is_constructible_v<std::span<int, 3>, volatile int (&)[3]>);
static_assert(!std::is_constructible_v<std::span<int, 3>, const volatile int (&)[3]>);

static_assert(!std::is_constructible<std::span<const int, 3>, volatile int(&)[3]>::value, "");
static_assert(!std::is_constructible<std::span<const int, 3>, const volatile int(&)[3]>::value, "");
static_assert(!std::is_constructible_v<std::span<const int, 3>, volatile int (&)[3]>);
static_assert(!std::is_constructible_v<std::span<const int, 3>, const volatile int (&)[3]>);

static_assert(!std::is_constructible<std::span<volatile int, 3>, const int(&)[3]>::value, "");
static_assert(!std::is_constructible<std::span<volatile int, 3>, const volatile int(&)[3]>::value, "");
static_assert(!std::is_constructible_v<std::span<volatile int, 3>, const int (&)[3]>);
static_assert(!std::is_constructible_v<std::span<volatile int, 3>, const volatile int (&)[3]>);
}

return 0;
Expand Down
Loading
Loading