Skip to content

[Xtensa] Support 'f' Inline Assembly Constraint #202345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gerekon wants to merge 1 commit into
base: main
Choose a base branch
from
+33 −9
Open

[Xtensa] Support 'f' Inline Assembly Constraint #202345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions llvm/lib/Target/Xtensa/XtensaISelLowering.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,7 @@ XtensaTargetLowering::getConstraintType(StringRef Constraint) const {
if (Constraint.size() == 1) {
switch (Constraint[0]) {
case 'r':
case 'f':
return C_RegisterClass;
default:
break;
Expand Down Expand Up @@ -316,6 +317,10 @@ XtensaTargetLowering::getSingleConstraintMatchWeight(
if (Ty->isIntegerTy())
Weight = CW_Register;
break;
case 'f':
if (Ty->isFloatingPointTy())
Weight = CW_Register;
break;
}
return Weight;
}
Expand All @@ -330,6 +335,9 @@ XtensaTargetLowering::getRegForInlineAsmConstraint(
break;
case 'r': // General-purpose register
return std::make_pair(0U, &Xtensa::ARRegClass);
case 'f': // Floating-point register
if (Subtarget.hasSingleFloat())
return std::make_pair(0U, &Xtensa::FPRRegClass);
}
}
return TargetLowering::getRegForInlineAsmConstraint(TRI, Constraint, VT);
Expand Down
23 changes: 23 additions & 0 deletions llvm/test/CodeGen/Xtensa/inline-asm-constraints.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
; RUN: llc -mtriple=xtensa -mcpu=esp32 -verify-machineinstrs < %s \
; RUN: | FileCheck -check-prefix=Xtensa %s


@gf = external global float

define float @constraint_f_float(float %a) nounwind {
; Xtensa-LABEL: constraint_f_float:
; Xtensa: # %bb.0:
; Xtensa-NEXT: entry a1, 32
; Xtensa-NEXT: wfr f8, a2
; Xtensa-NEXT: l32r a8, .LCPI0_0
; Xtensa-NEXT: lsi f9, a8, 0
; Xtensa-NEXT: #APP
; Xtensa-NEXT: add.s f8, f8, f9
; Xtensa-NEXT: #NO_APP
; Xtensa-NEXT: rfr a2, f8
; Xtensa-NEXT: retw
%1 = load float, float* @gf
%2 = tail call float asm "add.s $0, $1, $2", "=f,f,f"(float %a, float %1)
ret float %2
}

11 changes: 2 additions & 9 deletions llvm/test/CodeGen/Xtensa/inline-asm-invalid.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,7 @@
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 5
; RUN: not llc --mtriple=xtensa < %s 2>&1 | FileCheck %s
; RUN: not llc -mtriple=xtensa -mcpu=generic < %s 2>&1 | FileCheck %s

; CHECK: error: could not allocate input reg for constraint 'f'
define void @constraint_f() nounwind {
; CHECK: error: unknown asm constraint 'f'
tail call void asm "add.s f0, f1, $0", "f"(float 0.0)
ret void
}

define i32 @register_a100(i32 %a) nounwind {
; CHECK: error: could not allocate input reg for constraint '{$a100}'
%1 = tail call i32 asm "addi $0, $1, 1", "=r,{$a100}"(i32 %a)
ret i32 %1
}
Loading