Fixed the exception twisted.web._newclient.RequestGenerationFailed

Added @defer.inlineCallbacks before def is_wrong_issue to make twisted happy.

Author: slydiman

zorg/buildbot/reporters/utils.py

@@ -304,6 +304,7 @@ def _extract_issue(self, props):  # override
         log.msg(f"{self.name}._extract_issue: INFO: issue={issue}")
         return issue
 
+    @defer.inlineCallbacks
     def is_wrong_issue(self, repo_user, repo_name, sha, issue):
         # Users could reference wrong PRs in commit messages.
         # So, to make sure we are commenting the correct one we need to check
@@ -316,6 +317,7 @@ def is_wrong_issue(self, repo_user, repo_name, sha, issue):
             log.msg(
                 f"{self.name}.is_wrong_issue: WARNING: Skipped adding the comment for repo {repo_name}, issue is not specified."
             )
+            yield
             return wrong_issue
 
         page = 1
@@ -371,7 +373,8 @@ def createStatus(
         issue=None,
         description=None,
     ):  # override
-        if self.is_wrong_issue(repo_user, repo_name, sha, issue):
+        wrong_issue = yield self.is_wrong_issue(repo_user, repo_name, sha, issue)
+        if wrong_issue:
             return None
 
         # This is the right issue to comment.
@@ -383,10 +386,9 @@ def createStatus(
 
         # Use utils.LLVMFailGitHubReporter(debug=True, ...) to simulate the process.
         if self.debug:
-            yield
-            ret = None
-        else:
-            ret = yield self._http.post(url, json=payload)
+            return None
+
+        ret = yield self._http.post(url, json=payload)
         return ret
 
 
@@ -431,7 +433,8 @@ def createStatus(
         issue=None,
         description=None,
     ):  # override
-        if self.is_wrong_issue(repo_user, repo_name, sha, issue):
+        wrong_issue = yield self.is_wrong_issue(repo_user, repo_name, sha, issue)
+        if wrong_issue:
             return None
 
         # This is the right issue to label.
@@ -448,8 +451,7 @@ def createStatus(
 
         # Use utils.LLVMFailGitHubLabeler(debug=True, ... ) to simulate the process.
         if self.debug:
-            yield
-            ret = None
-        else:
-            ret = yield self._http.post(url, json=payload)
+            return None
+
+        ret = yield self._http.post(url, json=payload)
         return ret