use string instead of stringref

Author: EmilioLaiso

include/API/Device.h

@@ -63,7 +63,7 @@ class Device {
                size_t SizeInBytes) = 0;
 
   virtual llvm::Expected<std::shared_ptr<Texture>>
-  createTexture(llvm::StringRef Name, TextureCreateDesc &Desc) = 0;
+  createTexture(std::string Name, TextureCreateDesc &Desc) = 0;
 
   virtual void printExtra(llvm::raw_ostream &OS) {}
 

lib/API/DX/Device.cpp

@@ -404,7 +404,7 @@ class DXDevice : public offloadtest::Device {
   }
 
   llvm::Expected<std::shared_ptr<offloadtest::Texture>>
-  createTexture(llvm::StringRef Name, TextureCreateDesc &Desc) override {
+  createTexture(std::string Name, TextureCreateDesc &Desc) override {
     if (!isValidTextureUsageAndFormat(Desc.Usage, Desc.Format))
       return llvm::createStringError(
           std::errc::invalid_argument,

lib/API/MTL/MTLDevice.cpp

@@ -592,7 +592,7 @@ class MTLDevice : public offloadtest::Device {
   }
 
   llvm::Expected<std::shared_ptr<offloadtest::Texture>>
-  createTexture(llvm::StringRef Name, TextureCreateDesc &Desc) override {
+  createTexture(std::string Name, TextureCreateDesc &Desc) override {
     if (!isValidTextureUsageAndFormat(Desc.Usage, Desc.Format))
       return llvm::createStringError(
           std::errc::invalid_argument,
@@ -601,10 +601,9 @@ class MTLDevice : public offloadtest::Device {
           getTextureUsageName(Desc.Usage).c_str(),
           getTextureFormatName(Desc.Format).data());
 
-    MTL::TextureDescriptor *TDesc =
-        MTL::TextureDescriptor::texture2DDescriptor(
-            getMetalFormat(Desc.Format), Desc.Width, Desc.Height,
-            Desc.MipLevels > 1);
+    MTL::TextureDescriptor *TDesc = MTL::TextureDescriptor::texture2DDescriptor(
+        getMetalFormat(Desc.Format), Desc.Width, Desc.Height,
+        Desc.MipLevels > 1);
     TDesc->setMipmapLevelCount(Desc.MipLevels);
     TDesc->setStorageMode(getMetalStorageMode(Desc.Location));
     TDesc->setUsage(getMetalTextureUsage(Desc.Usage));

lib/API/VK/Device.cpp

@@ -672,7 +672,7 @@ class VulkanDevice : public offloadtest::Device {
   }
 
   llvm::Expected<std::shared_ptr<offloadtest::Texture>>
-  createTexture(llvm::StringRef Name, TextureCreateDesc &Desc) override {
+  createTexture(std::string Name, TextureCreateDesc &Desc) override {
     if (!isValidTextureUsageAndFormat(Desc.Usage, Desc.Format))
       return llvm::createStringError(
           std::errc::invalid_argument,