pr feedback: rename functions and remove comments

Author: EmilioLaiso

include/API/Device.h

@@ -90,11 +90,11 @@ initializeDevices(const DeviceConfig Config);
 // CPUBuffer. Does not upload the buffer's data — only uses its description to
 // configure the texture.
 llvm::Expected<std::shared_ptr<Texture>>
-createRenderTarget(Device &Dev, const CPUBuffer &Buf);
+createRenderTargetFromCPUBuffer(Device &Dev, const CPUBuffer &Buf);
 
 // Creates a depth/stencil texture matching the dimensions of a render target.
 llvm::Expected<std::shared_ptr<Texture>>
-createDepthStencil(Device &Dev, uint32_t Width, uint32_t Height);
+createDefaultDepthStencilTarget(Device &Dev, uint32_t Width, uint32_t Height);
 
 } // namespace offloadtest
 

lib/API/DX/Device.cpp

@@ -437,7 +437,8 @@ class DXDevice : public offloadtest::Device {
 
     D3D12_RESOURCE_DESC TexDesc = {};
     TexDesc.Dimension = D3D12_RESOURCE_DIMENSION_TEXTURE2D;
-    TexDesc.Width = Desc.Width, TexDesc.Height = Desc.Height,
+    TexDesc.Width = Desc.Width;
+    TexDesc.Height = Desc.Height;
     TexDesc.DepthOrArraySize = 1;
     TexDesc.MipLevels = static_cast<UINT16>(Desc.MipLevels);
     TexDesc.Format = getDXGIFormat(Desc.Format);
@@ -1499,7 +1500,7 @@ class DXDevice : public offloadtest::Device {
           "No render target bound for graphics pipeline.");
     const CPUBuffer &OutBuf = *P.Bindings.RTargetBufferPtr;
 
-    auto TexOrErr = offloadtest::createRenderTarget(*this, OutBuf);
+    auto TexOrErr = offloadtest::createRenderTargetFromCPUBuffer(*this, OutBuf);
     if (!TexOrErr)
       return TexOrErr.takeError();
 
@@ -1517,7 +1518,7 @@ class DXDevice : public offloadtest::Device {
   }
 
   llvm::Error createDepthStencil(Pipeline &P, InvocationState &IS) {
-    auto TexOrErr = offloadtest::createDepthStencil(
+    auto TexOrErr = offloadtest::createDefaultDepthStencilTarget(
         *this, P.Bindings.RTargetBufferPtr->OutputProps.Width,
         P.Bindings.RTargetBufferPtr->OutputProps.Height);
     if (!TexOrErr)

lib/API/Device.cpp

@@ -48,7 +48,8 @@ offloadtest::initializeDevices(const DeviceConfig Config) {
 }
 
 llvm::Expected<std::shared_ptr<Texture>>
-offloadtest::createRenderTarget(Device &Dev, const CPUBuffer &Buf) {
+offloadtest::createRenderTargetFromCPUBuffer(Device &Dev,
+                                             const CPUBuffer &Buf) {
   auto TexFmtOrErr = toFormat(Buf.Format, Buf.Channels);
   if (!TexFmtOrErr)
     return TexFmtOrErr.takeError();
@@ -69,7 +70,8 @@ offloadtest::createRenderTarget(Device &Dev, const CPUBuffer &Buf) {
 }
 
 llvm::Expected<std::shared_ptr<Texture>>
-offloadtest::createDepthStencil(Device &Dev, uint32_t Width, uint32_t Height) {
+offloadtest::createDefaultDepthStencilTarget(Device &Dev, uint32_t Width,
+                                             uint32_t Height) {
   TextureCreateDesc Desc = {};
   Desc.Location = MemoryLocation::GpuOnly;
   Desc.Usage = TextureUsage::DepthStencil;

lib/API/MTL/MTLDevice.cpp

@@ -466,7 +466,7 @@ class MTLDevice : public offloadtest::Device {
           "No render target bound for graphics pipeline.");
     const CPUBuffer &OutBuf = *P.Bindings.RTargetBufferPtr;
 
-    auto TexOrErr = offloadtest::createRenderTarget(*this, OutBuf);
+    auto TexOrErr = offloadtest::createRenderTargetFromCPUBuffer(*this, OutBuf);
     if (!TexOrErr)
       return TexOrErr.takeError();
 
@@ -484,7 +484,7 @@ class MTLDevice : public offloadtest::Device {
   }
 
   llvm::Error createDepthStencil(Pipeline &P, InvocationState &IS) {
-    auto TexOrErr = offloadtest::createDepthStencil(
+    auto TexOrErr = offloadtest::createDefaultDepthStencilTarget(
         *this, P.Bindings.RTargetBufferPtr->OutputProps.Width,
         P.Bindings.RTargetBufferPtr->OutputProps.Height);
     if (!TexOrErr)

lib/API/VK/Device.cpp

@@ -1137,7 +1137,7 @@ class VulkanDevice : public offloadtest::Device {
           "No render target bound for graphics pipeline.");
     const CPUBuffer &RTBuf = *P.Bindings.RTargetBufferPtr;
 
-    auto TexOrErr = offloadtest::createRenderTarget(*this, RTBuf);
+    auto TexOrErr = offloadtest::createRenderTargetFromCPUBuffer(*this, RTBuf);
     if (!TexOrErr)
       return TexOrErr.takeError();
 
@@ -1155,7 +1155,7 @@ class VulkanDevice : public offloadtest::Device {
   }
 
   llvm::Error createDepthStencil(Pipeline &P, InvocationState &IS) {
-    auto TexOrErr = offloadtest::createDepthStencil(
+    auto TexOrErr = offloadtest::createDefaultDepthStencilTarget(
         *this, P.Bindings.RTargetBufferPtr->OutputProps.Width,
         P.Bindings.RTargetBufferPtr->OutputProps.Height);
     if (!TexOrErr)
@@ -2377,9 +2377,6 @@ class VulkanDevice : public offloadtest::Device {
         vkDestroyBuffer(Device, IS.VertexBuffer->Host.Buffer, nullptr);
         vkFreeMemory(Device, IS.VertexBuffer->Host.Memory, nullptr);
       }
-      // Render target image and readback buffer are owned by
-      // Render target, readback buffer, and depth stencil are owned by
-      // shared_ptrs (IS.RenderTarget, IS.RTReadback, IS.DepthStencil).
       vkDestroyFramebuffer(Device, IS.FrameBuffer, nullptr);
       vkDestroyRenderPass(Device, IS.RenderPass, nullptr);
     }