Skip to content

Commit beeaa3d

Browse files
Remove error about mip levels not being supported in DX12 because they are implemented.
1 parent 24adb48 commit beeaa3d

2 files changed

Lines changed: 2 additions & 7 deletions

File tree

lib/API/DX/Device.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2407,7 +2407,7 @@ class DXDevice : public offloadtest::Device {
24072407
llvm::Error
24082408
createComputeCommands(Pipeline &P, SharedInvocationState &IS,
24092409
const ComPtr<ID3D12DescriptorHeap> &DescHeap) {
2410-
DXCommandBuffer &DXCB = llvm::cast<DXCommandBuffer>(*IS.CB);
2410+
const DXCommandBuffer &DXCB = llvm::cast<DXCommandBuffer>(*IS.CB);
24112411

24122412
CD3DX12_GPU_DESCRIPTOR_HANDLE Handle;
24132413
if (DescHeap) {
@@ -2540,7 +2540,7 @@ class DXDevice : public offloadtest::Device {
25402540
const ComPtr<ID3D12DescriptorHeap> &DescHeap) {
25412541
const DXPipelineState &DXPipeline =
25422542
llvm::cast<DXPipelineState>(*IS.Pipeline.get());
2543-
DXCommandBuffer &DXCB = llvm::cast<DXCommandBuffer>(*IS.CB);
2543+
const DXCommandBuffer &DXCB = llvm::cast<DXCommandBuffer>(*IS.CB);
25442544

25452545
DXCB.CmdList->SetGraphicsRootSignature(DXPipeline.RootSig.Get());
25462546
if (DescHeap) {

lib/Support/OffloadMigration.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -256,11 +256,6 @@ llvm::Error createResources(Device &Dev, Pipeline &P,
256256
ResBundle.push_back(std::move(RSet));
257257
}
258258
} else if (R.isTexture()) {
259-
if (R.BufferPtr->OutputProps.MipLevels != 1)
260-
return llvm::createStringError(std::errc::not_supported,
261-
"Multiple mip levels are not yet "
262-
"supported for DirectX textures.");
263-
264259
auto FormatOrErr = toFormat(R.BufferPtr->Format, R.BufferPtr->Channels);
265260
if (!FormatOrErr)
266261
return FormatOrErr.takeError();

0 commit comments

Comments
 (0)