Skip to content

Commit e536eaf

Browse files
authored
Update ByteAddressBuffer Load/Store XFAILs (#710)
1 parent 5aa4602 commit e536eaf

3 files changed

Lines changed: 10 additions & 10 deletions

File tree

test/Feature/ByteAddressBuffer/ByteAddressBuffers-16bit.test

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,8 @@ DescriptorSets:
8888
...
8989
#--- end
9090

91-
# Unimplemented https://github.com/llvm/llvm-project/issues/108058
92-
# XFAIL: Clang
91+
# Unimplemented https://github.com/llvm/llvm-project/issues/179560
92+
# XFAIL: Clang && Vulkan
9393

9494
# REQUIRES: Int16
9595
# RUN: split-file %s %t

test/Feature/ByteAddressBuffer/ByteAddressBuffers-64bit.test

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,8 @@ DescriptorSets:
8888
...
8989
#--- end
9090

91-
# Unimplemented https://github.com/llvm/llvm-project/issues/108058
92-
# XFAIL: Clang
91+
# Unimplemented https://github.com/llvm/llvm-project/issues/179560
92+
# XFAIL: Clang && Vulkan
9393

9494
# REQUIRES: Int64
9595
# RUN: split-file %s %t

test/Feature/ByteAddressBuffer/ByteAddressBuffers.test

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -49,19 +49,19 @@ void main() {
4949
// bool
5050
bool U4 = In0.Load<bool>(64);
5151
bool V4 = In1.Load<bool>(64);
52-
Out.Store<bool>(64, U4 + V4);
52+
Out.Store<bool>(64, or(U4, V4));
5353

5454
bool2 U5 = In0.Load<bool2>(64);
5555
bool2 V5 = In1.Load<bool2>(64);
56-
Out.Store<bool2>(80, U5 + V5);
56+
Out.Store<bool2>(80, or(U5, V5));
5757

5858
bool3 U6 = In0.Load<bool3>(64);
5959
bool3 V6 = In1.Load<bool3>(64);
60-
Out.Store<bool3>(96, U6 + V6);
60+
Out.Store<bool3>(96, or(U6, V6));
6161

6262
bool4 U7 = In0.Load<bool4>(64);
6363
bool4 V7 = In1.Load<bool4>(64);
64-
Out.Store<bool4>(112, U7 + V7);
64+
Out.Store<bool4>(112, or(U7, V7));
6565

6666
// structs
6767
ArrayStruct U8 = In0.Load<ArrayStruct>(0);
@@ -148,8 +148,8 @@ DescriptorSets:
148148
...
149149
#--- end
150150

151-
# Unimplemented https://github.com/llvm/llvm-project/issues/108058
152-
# XFAIL: Clang
151+
# Unimplemented https://github.com/llvm/llvm-project/issues/179560
152+
# XFAIL: Clang && Vulkan
153153

154154
# RUN: split-file %s %t
155155
# RUN: %dxc_target -T cs_6_5 -Fo %t.o %t/source.hlsl

0 commit comments

Comments
 (0)