Add Queue::submit() for command buffer submission#1057
Draft
Add Queue::submit() for command buffer submission#1057
Queue::submit() for command buffer submission#1057Conversation
MarijnS95
force-pushed
the
queue-submit
branch
2 times, most recently
from
b77026f to
b8bd9ac
Compare
Contributor
Author
|
Looks like this needs some more TLC, from CI: |
MarijnS95
force-pushed
the
queue-submit
branch
5 times, most recently
from
5e4f6d2 to
3b4f680
Compare
MarijnS95
force-pushed
the
queue-submit
branch
3 times, most recently
from
0ed7539 to
cfb2665
Compare
Move command buffer submission logic from each backend's Device into Queue::submit(), which takes ownership of the command buffers. Each backend uses its Fence abstraction for GPU synchronization: - Metal: commit() + waitUntilCompleted() - Vulkan: vkQueueSubmit() signaling a timeline semaphore (VulkanFence), then VulkanFence::waitForCompletion() - DX12: ExecuteCommandLists() + Queue::Signal() on the queue-owned DXFence, then DXFence::waitForCompletion() Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1033
Move command buffer submission logic from each backend's
DeviceintoQueue::submit(), which takes ownership of the command buffers. Each backend uses itsFenceabstraction (#1007) for GPU synchronization:commit()+waitUntilCompleted()vkQueueSubmit()signaling a timeline semaphore (VulkanFence), thenVulkanFence::waitForCompletion()ExecuteCommandLists()+Queue::Signal()on the queue-ownedDXFence, thenDXFence::waitForCompletion()Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com