Add tessellation support to DX/VK backends with accompanying SimpleTriangleTess.test#1224
Merged
Merged
Conversation
MarijnS95
reviewed
May 26, 2026
Comment on lines
+95
to
+96
| // Hull and Domain are independent optionals here; Pipeline.cpp enforces that | ||
| // they must be set as a pair (and only with PatchList topology). |
Collaborator
There was a problem hiding this comment.
If both must be set, there're not independent, but dependent or interdependent?
Collaborator
There was a problem hiding this comment.
In-person: the here was referring to the two std::optional<>s below allowing them to be independent while they're not supposed to be independent. I would reword that to be more like the latter sentence to make the intent clear :)
Contributor
There was a problem hiding this comment.
I think the comment is fine.
MarijnS95
reviewed
May 26, 2026
| PrimitiveTopology Topology = PrimitiveTopology::TriangleList; | ||
|
|
||
| // Set if Topology == PatchList. Validated in | ||
| // Pipeline.cpp::validatePipelineKind. Valid range is 1..32 (matches both |
Collaborator
There was a problem hiding this comment.
Only if you're making changes (resolving comments via Claude...) anyway:
Suggested change
| // Pipeline.cpp::validatePipelineKind. Valid range is 1..32 (matches both | |
| // Pipeline.cpp::validatePipelineKind(). Valid range is 1..32 (matches both |
MarijnS95
approved these changes
May 26, 2026
manon-traverse
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
HullandDomainshader support, plus aPatchListprimitive topology with per-call control-point count.Wires the new stages on the DX12 and Vulkan backends.
Metal explicitly rejects them. Metal's tessellation model (HS as a compute kernel, DS as a
[[patch(...)]]-tagged vertex function) doesn't neatly fit the HS/DS shape, so the path is intentionally left unimplemented.Adds one end-to-end test,
SimpleTriangleTess.test, exercising a VS → HS → DS → PS pipeline that renders theSimpleTriangleimage test via tessellation.