Skip to content

Fix warnings that cause main to fail CI. #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
manon-traverse wants to merge 1 commit into from
Closed

Fix warnings that cause main to fail CI. #1233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/API/DX/Device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -978,6 +978,7 @@ class DXDevice : public offloadtest::Device {
DSVAllocator(std::move(DSVAllocator)) {
Description = std::move(Desc);
DriverName = "DirectX";
DriverVersion = DriverVer;

@bogner bogner May 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
DriverVersion = DriverVer;

@bogner bogner May 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I thought I'd be able to apply this suggestion and then merge this to get the CI going, but apparently I don't have that power. Putting up my own PR #1242 so I can merge this now.

}
DXDevice(const DXDevice &) = delete;
DXDevice &operator=(const DXDevice &) = delete;
Expand Down Expand Up @@ -2372,7 +2373,7 @@ class DXDevice : public offloadtest::Device {
for (const ResourceSet &RS : R.second) {
if (RS.Readback == nullptr)
continue;
DXBuffer &ReadbackDX = llvm::cast<DXBuffer>(*RS.Readback);
const DXBuffer &ReadbackDX = llvm::cast<DXBuffer>(*RS.Readback);
addReadbackBeginBarrier(IS, RS.Buffer);
const CD3DX12_TEXTURE_COPY_LOCATION DstLoc(ReadbackDX.Buffer.Get(),
Footprint);
Expand All @@ -2385,7 +2386,7 @@ class DXDevice : public offloadtest::Device {
for (const ResourceSet &RS : R.second) {
if (RS.Readback == nullptr)
continue;
DXBuffer &ReadbackDX = llvm::cast<DXBuffer>(*RS.Readback);
const DXBuffer &ReadbackDX = llvm::cast<DXBuffer>(*RS.Readback);
addReadbackBeginBarrier(IS, RS.Buffer);
IS.CB->CmdList->CopyResource(ReadbackDX.Buffer.Get(), RS.Buffer.Get());
addReadbackEndBarrier(IS, RS.Buffer);
Expand Down
Loading