Add the mesh shader pipeline creation function to the Device base class.#1246
Merged
manon-traverse merged 3 commits intoJun 9, 2026
Merged
Conversation
MarijnS95
approved these changes
Jun 3, 2026
d890ab0 to
028a6cf
Compare
bogner
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mesh shader pipeline creation function was not part of the Device base class. This PR adds it to the base class, and also introduces a create description similar to the traditional raster pipeline creation function.
Additionally support for specifying the topology has also been added. This is only needed in DX12 since both Vulkan and Metal just extract the topology type from the shader byte code.
Technically DX12 only cares about the topology type (triangles vs lines, instead triangle list vs triangle strip), but I think it is overkill to introduce a new enum for topology types to the .yaml file if we can just use a topology type instead.