Skip to content

[Utils] Add xfail sync script#1301

Closed
bob80905 wants to merge 3 commits into
llvm:mainfrom
bob80905:add_xfail_sync
Closed

[Utils] Add xfail sync script#1301
bob80905 wants to merge 3 commits into
llvm:mainfrom
bob80905:add_xfail_sync

Conversation

@bob80905

@bob80905 bob80905 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

This PR implements a way to track the XFAILs that have been added to the offload test suite.
There are 2 failure cases this script is able to catch.

  1. A test that has consistent failures is missing an XFAIL annotation, and should have an XFAIL annotation added.
  2. A test that already has an XFAIL annotation is consistently passing, and should have its XFAIL annotation removed.

Here is the output of the script when run:
image

Addresses #1300
Assisted by: Github Copilot

@bogner

bogner commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

I'm not really convinced this is useful. Most of the time the first time something fails or xpasses it's pretty obvious what we should do with it, so I expect the frequency with which this gives us any extra information to be low.

@bogner

bogner commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

I've put up #1303 which I think gives a better overview of what's currently happening and might be sufficient instead of this.

@bob80905

Copy link
Copy Markdown
Contributor Author

Talked with Justin offline, I'll close this in favor of
#1303

@bob80905 bob80905 closed this Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants