Skip to content

Add support for 64-bit formats. #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manon-traverse merged 3 commits into from
Jun 12, 2026
Merged

Add support for 64-bit formats. #1302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
09f544b
Add support for 64-bit formats.
manon-traverse Jun 10, 2026
fe96055
Add yaml format mapping to Format enum mapping for 64-bit integer types.
manon-traverse Jun 10, 2026
2f5d104
Add clarifying comments about 64-bit formats.
manon-traverse Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions include/API/FormatConversion.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,13 +87,29 @@ inline llvm::Expected<Format> toFormat(DataFormat Format, int Channels) {
if (Channels == 1)
return Format::D32Float;
break;
case DataFormat::UInt64:
// Only 1 and 2 channels of 64-bit integers are supported.
switch (Channels) {
case 1:
return Format::R64Uint;
case 2:
Comment thread
bob80905 marked this conversation as resolved.
return Format::RG64Uint;
}
break;
case DataFormat::Int64:
// Only 1 and 2 channels of 64-bit integers are supported.
switch (Channels) {
case 1:
return Format::R64Sint;
case 2:
return Format::RG64Sint;
}
break;
// No Format mapping for these DataFormats.
case DataFormat::Hex8:
case DataFormat::Hex16:
case DataFormat::Hex32:
case DataFormat::Hex64:
case DataFormat::UInt64:
case DataFormat::Int64:
case DataFormat::Float16:
case DataFormat::Float64:
case DataFormat::Bool:
Expand Down
37 changes: 37 additions & 0 deletions include/API/Resources.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@ enum class Format {
RGBA32Sint,
RGBA32Uint,
RGBA32Float,
R64Uint,
R64Sint,
RG64Uint,
RG64Sint,
D32Float,
D32FloatS8Uint,
};
Expand Down Expand Up @@ -85,6 +89,14 @@ inline llvm::StringRef getFormatName(Format Format) {
return "RGBA32Uint";
case Format::RGBA32Float:
return "RGBA32Float";
case Format::R64Uint:
return "R64Uint";
case Format::R64Sint:
return "R64Sint";
case Format::RG64Uint:
return "RG64Uint";
case Format::RG64Sint:
return "RG64Sint";
case Format::D32Float:
return "D32Float";
case Format::D32FloatS8Uint:
Expand Down Expand Up @@ -112,12 +124,16 @@ inline uint32_t getFormatSizeInBytes(Format Format) {
case Format::RG32Uint:
case Format::RG32Float:
case Format::D32FloatS8Uint:
case Format::R64Uint:
case Format::R64Sint:
return 8;
case Format::RGB32Float:
return 12;
case Format::RGBA32Sint:
case Format::RGBA32Uint:
case Format::RGBA32Float:
case Format::RG64Uint:
case Format::RG64Sint:
return 16;
}
llvm_unreachable("All Format cases handled");
Expand All @@ -141,6 +157,10 @@ inline bool isDepthFormat(Format Format) {
case Format::RGBA32Sint:
case Format::RGBA32Uint:
case Format::RGBA32Float:
case Format::R64Uint:
case Format::R64Sint:
case Format::RG64Uint:
case Format::RG64Sint:
return false;
case Format::D32Float:
case Format::D32FloatS8Uint:
Expand All @@ -167,6 +187,10 @@ inline bool isStencilFormat(Format Format) {
case Format::RGBA32Sint:
case Format::RGBA32Uint:
case Format::RGBA32Float:
case Format::R64Uint:
case Format::R64Sint:
case Format::RG64Uint:
case Format::RG64Sint:
case Format::D32Float:
return false;
case Format::D32FloatS8Uint:
Expand Down Expand Up @@ -199,6 +223,11 @@ inline bool isTextureCompatible(Format Format) {
case Format::RGBA32Float:
case Format::D32Float:
case Format::D32FloatS8Uint:
// Only for RWTextures
case Format::R64Uint:
case Format::R64Sint:
case Format::RG64Uint:
case Format::RG64Sint:
Comment on lines +226 to +230

@EmilioLaiso EmilioLaiso Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then should we have isRwTextureCompatible ?

@manon-traverse manon-traverse Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. Like you can still have an SRV for these and load it as a regular texture, but you can't use a sampler on it from what I understand. It's one of these edge cases where there is no clear yes/no answer on 'can we create a texture with this format'.

return true;
}
llvm_unreachable("All Format cases handled");
Expand All @@ -224,6 +253,10 @@ inline bool isVertexCompatible(Format Format) {
case Format::RGBA32Uint:
case Format::RGBA32Float:
return true;
case Format::R64Uint:
case Format::R64Sint:
case Format::RG64Uint:
case Format::RG64Sint:
case Format::D32Float:
case Format::D32FloatS8Uint:
return false;
Expand Down Expand Up @@ -253,6 +286,10 @@ inline bool isPositionCompatible(Format Format) {
case Format::RG32Uint:
case Format::RGBA32Sint:
case Format::RGBA32Uint:
case Format::R64Uint:
case Format::R64Sint:
case Format::RG64Uint:
case Format::RG64Sint:
case Format::D32Float:
case Format::D32FloatS8Uint:
return false;
Expand Down
14 changes: 12 additions & 2 deletions lib/API/DX/DXResources.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ inline D3D12_HEAP_TYPE getDXHeapType(MemoryLocation Location) {
llvm_unreachable("All MemoryLocation cases handled");
}

inline DXGI_FORMAT getDXGIFormat(Format Format) {
switch (Format) {
inline DXGI_FORMAT getDXGIFormat(Format Fmt) {
switch (Fmt) {
case Format::R16Sint:
return DXGI_FORMAT_R16_SINT;
case Format::R16Uint:
Expand Down Expand Up @@ -65,6 +65,16 @@ inline DXGI_FORMAT getDXGIFormat(Format Format) {
return DXGI_FORMAT_R32G32B32A32_UINT;
case Format::RGBA32Float:
return DXGI_FORMAT_R32G32B32A32_FLOAT;
case Format::R64Uint:
Comment thread
bob80905 marked this conversation as resolved.
return DXGI_FORMAT_R32G32_UINT; // DXGI has no R64, DX12 expects R32G32
case Format::R64Sint:
return DXGI_FORMAT_R32G32_SINT; // DXGI has no R64, DX12 expects R32G32
case Format::RG64Uint:
return DXGI_FORMAT_R32G32B32A32_UINT; // DXGI has no R64G64, DX12 expects
// R32G32G32B32
case Format::RG64Sint:
return DXGI_FORMAT_R32G32B32A32_SINT; // DXGI has no R64G64, DX12 expects
// R32G32G32B32
case Format::D32Float:
return DXGI_FORMAT_D32_FLOAT;
case Format::D32FloatS8Uint:
Expand Down
12 changes: 12 additions & 0 deletions lib/API/MTL/MTLResources.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,12 @@ inline MTL::PixelFormat getMetalPixelFormat(Format Format) {
return MTL::PixelFormatRGBA32Uint;
case Format::RGBA32Float:
return MTL::PixelFormatRGBA32Float;
// Metal has no 64-bit-per-channel pixel formats.
case Format::R64Uint:
case Format::R64Sint:
case Format::RG64Uint:
case Format::RG64Sint:
llvm_unreachable("64-bit formats have no Metal pixel format equivalent");
case Format::D32Float:
return MTL::PixelFormatDepth32Float;
case Format::D32FloatS8Uint:
Expand Down Expand Up @@ -140,6 +146,12 @@ inline MTL::VertexFormat getMetalVertexFormat(Format Fmt) {
return MTL::VertexFormatUInt4;
case Format::RGBA32Float:
return MTL::VertexFormatFloat4;
// Metal has no 64-bit-per-channel vertex formats.
case Format::R64Uint:
case Format::R64Sint:
case Format::RG64Uint:
case Format::RG64Sint:
llvm_unreachable("64-bit formats have no Metal vertex format equivalent");
// Depth formats cannot be used as vertex attributes.
case Format::D32Float:
case Format::D32FloatS8Uint:
Expand Down
8 changes: 8 additions & 0 deletions lib/API/VK/VKResources.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,14 @@ inline VkFormat getVulkanFormat(Format Format) {
return VK_FORMAT_R32G32B32A32_UINT;
case Format::RGBA32Float:
return VK_FORMAT_R32G32B32A32_SFLOAT;
case Format::R64Uint:
return VK_FORMAT_R64_UINT;
case Format::R64Sint:
return VK_FORMAT_R64_SINT;
case Format::RG64Uint:
return VK_FORMAT_R64G64_UINT;
case Format::RG64Sint:
return VK_FORMAT_R64G64_SINT;
case Format::D32Float:
return VK_FORMAT_D32_SFLOAT;
case Format::D32FloatS8Uint:
Expand Down
Loading