Hull and Domain shader system-value tests#1304
Merged
EmilioLaiso merged 3 commits intoJun 18, 2026
Merged
Conversation
Comment on lines
+199
to
+210
| - Name: ResultBuffer_Expected | ||
| Format: Hex32 | ||
| Stride: 28 | ||
| # Per-pixel expected records: | ||
| # PCPrimID, HSMainPrimID, Cpid0, Cpid1, Cpid2, EdgeFactor, InsideFactor | ||
| # 1.0 -> 0x3F800000 | ||
| Data: [ | ||
| # idx0: patch 0 | ||
| 0x0, 0x0, 0x0, 0x1, 0x2, 0x3F800000, 0x3F800000, | ||
| # idx1: patch 1 | ||
| 0x1, 0x1, 0x0, 0x1, 0x2, 0x3F800000, 0x3F800000, | ||
| ] |
Contributor
There was a problem hiding this comment.
Perhaps we should use two buffers if we are missing floats and integers? What do you think?
manon-traverse
approved these changes
Jun 11, 2026
bogner
approved these changes
Jun 12, 2026
EmilioLaiso
force-pushed
the
hull-and-domain-system-values-tests
branch
from
d33a3dd to
f1398d5
Compare
EmilioLaiso
force-pushed
the
hull-and-domain-system-values-tests
branch
from
f1398d5 to
6cdafb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both tests validate the tessellation system values directly (capturing them into a
RWStructuredBufferand checking withResults: BufferExact), rather than inferring them from a rendered image.HullSystemValues.testValidates:
SV_PrimitiveIDin both the patch-constant function and HSmain.SV_OutputControlPointID. Each invocation sees its own index{0,1,2}.SV_TessFactor/SV_InsideTessFactor. Round-tripped HS -> DS and checked.DomainSystemValues.testValidates:
SV_PrimitiveIDas a DS input. Not exercised by any other test.SV_DomainLocation— exact(u,v)per pixel (same mapping proven inQuadDomainTessellation.test, captured here as exact floats).SV_Position(DS output → rasterizer → PS). Exact pixel centers.Part of #1146