Skip to content

[Metal] MTLDevice BufferCreateDesc needs to be fully initalized #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
farzonl merged 1 commit into from
Jun 15, 2026
+5 −1
Merged

[Metal] MTLDevice BufferCreateDesc needs to be fully initalized #1312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/API/MTL/MTLDevice.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1414,7 +1414,11 @@ class MTLDevice : public offloadtest::Device {
Contributions.push_back(Inst.InstanceContributionToHitGroupIndex &
0xFFFFFFu);
const BufferCreateDesc Desc{MemoryLocation::GpuToCpu,
BufferUsage::Storage};
MemoryBacking::Automatic,
BufferUsage::Storage,
BufferShaderAccessType::Raw,
{},
false};
Comment on lines 1416 to +1421

@bogner bogner Jun 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this use one of the static BufferCreateDesc helper functions instead? BufferCreateDesc::readBackBuffer I guess?

auto ContribBufOrErr = createBufferWithData(
*IS.CB->Dev, "AS-Contributions", Desc, Contributions.data(),
InstCount * sizeof(uint32_t), nullptr, nullptr);
Expand Down
Loading