Pass warp architecture through to lit configuration#1317
Merged
Conversation
manon-traverse
approved these changes
Jun 17, 2026
farzonl
reviewed
Jun 17, 2026
| dxc_path="$GITHUB_WORKSPACE/dxc-dist/bin/dxc" | ||
| if [ -x "${dxc_path}.exe" ]; then dxc_path="${dxc_path}.exe"; fi | ||
| warp_arch_args=() | ||
| if [ '${{ inputs.OS }}' = 'windows' ]; then |
Member
There was a problem hiding this comment.
Why do we need to check windows. If the user wants to pick warp windows should be assumed no?
Collaborator
Author
There was a problem hiding this comment.
In the workflow we don't actually know that we're configuring for warp. It probably wouldn't harm anything to set this always (I just didn't trace through all the places where WARP_ARCHITECTURE might impact something). It also might be better to just have a more generalized way of feeding lit the host architecture, but I think that would be a bigger change.
farzonl
approved these changes
Jun 17, 2026
bob80905
approved these changes
Jun 17, 2026
Icohedron
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This passes the warp architecture through to the lit configurations so that the features are configured correctly.