Improve logging on mismatched values#1318
Merged
llvm-beanz merged 2 commits intoJun 17, 2026
Merged
Conversation
This change is just intended to improve the logging for mismatched values by logging the specific value that mismatched (helpful for large comparison buffers) and printing floathex or hex depending on of the value is a floating point type.
llvm-beanz
changed the title
V-FEXrt
approved these changes
Jun 17, 2026
manon-traverse
approved these changes
Jun 17, 2026
bob80905
approved these changes
Jun 17, 2026
bob80905
left a comment
bob80905
left a comment
Contributor
There was a problem hiding this comment.
This LGTM, but I must say I do like the early return like before.
If we encounter a large buffer array like you mention, then we may see "Mismatch at element..." repeated hundreds of times, when only the first mismatch might be enough for our purposes.
It could potentially blow up the log size on the pipelines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is just intended to improve the logging for mismatched values by logging the specific value that mismatched (helpful for large comparison buffers) and printing floathex or hex depending on of the value is a floating point type.