Skip to content

Improve logging on mismatched values #1318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
llvm-beanz merged 2 commits into from
Jun 17, 2026
Merged

Improve logging on mismatched values #1318

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97e0ec9
[NFC] Improve logging on mismatched values
llvm-beanz Jun 17, 2026
2f59943
clang-format
llvm-beanz Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions lib/Support/Check.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
#include <cmath>
#include <cstring>
#include <sstream>
#include <type_traits>

constexpr uint16_t Float16BitSign = 0x8000;
constexpr uint16_t Float16BitExp = 0x7c00;
Expand Down Expand Up @@ -178,11 +179,24 @@ static bool testAll(std::function<bool(const T &, const T &)> ComparisonFn,
if (Arr1.size() != Arr2.size())
return false;

bool Passed = true;
for (size_t I = 0, E = Arr1.size(); I < E; ++I) {
if (!ComparisonFn(Arr1[I], Arr2[I]))
return false;
if (!ComparisonFn(Arr1[I], Arr2[I])) {
std::ostringstream ActStr, ExpStr;
if constexpr (std::is_floating_point_v<T>) {
ActStr << Arr1[I] << " (" << std::hexfloat << Arr1[I] << ")";
ExpStr << Arr2[I] << " (" << std::hexfloat << Arr2[I] << ")";
} else {
ActStr << "0x" << std::hex << Arr1[I];
ExpStr << "0x" << std::hex << Arr2[I];
}
llvm::errs() << " Mismatch at element " << I
<< ": expected=" << ExpStr.str()
<< ", actual=" << ActStr.str() << "\n";
Passed = false;
}
}
return true;
return Passed;
}

template <typename T>
Expand Down
Loading