Move resource creation, readbacks, and InvocationState from DX backend to shared file.#1330
Conversation
…d to shared file.
…y are implemented.
2514b33 to
beeaa3d
Compare
…mipmap creation is supported on dx12.
bogner
left a comment
There was a problem hiding this comment.
Will this stay in Support/ long term, or is the intent to eventually move it again once everything is migrated?
Overall LGTM on the assumption that the follow ups are where doing this will really shine.
| # Unimplemented: Clang + DX: https://github.com/llvm/llvm-project/issues/101558 | ||
| # XFAIL: DirectX |
There was a problem hiding this comment.
Shouldn't this change be NFC? Why does this start passing?
There was a problem hiding this comment.
This stems from the fact that DX12 already supported mip levels, but the mip levels were forced to 1. By using the mip level count from the Resource instead of clamping it this test started succeeding.
The eventual goal is that all of this will live in the offload application, since this is all just code that is specific to running a .test file, i.e. what the offloader is for. |
|
This PR is only failing on irrelevant tests due to a bug in the CI system itself. Safe to merge. |
Move code that doesn't need to live in the DX backend to a shared file.
Why make this change?
This PR doesn't make any other code changes other than splitting the creation of the descriptor tables into a separate function from resource creation, due to no abstraction existing for building descriptor sets/tables and binding those yet.