Add minutes for HLSL Working Group meeting on 2026-04-30#418
Open
farzonl wants to merge 1 commit into
Open
Conversation
This covers discussion topics known and to be added during the meeting.
farzonl
commented
Apr 30, 2026
| * https://github.com/llvm/llvm-project/issues/194293 (VUID-StandaloneSpirv-Flat-04744) Flat anonotations | ||
| * Matrix Layout Keywords Proposal Update: | ||
| * @farzonl wants to add a new AttributedType for Matrix Layout Keywords to eliminate all walking to find Decls (per-call-site discovery). | ||
| * Every existing call site already has a QualType so this becomes an easy lookup on the type |
Member
Author
There was a problem hiding this comment.
Problem:
- per-call-site discovery is a problem. We don't always have access to the Decl in codegen
Solution:
- Carry it on the type via AttributedType sugar
- The layout becomes a property of the matrix value's type, which is exactly what the language semantics say it is.
- When Sema applies
hlsl::row_majorto a VarDecl/FieldDecl/TypedefDecl, also wrap the declared QualType inAttributedType(attr_hlsl_row_major, …, ConstantMatrixType). Field/var/typedef types already propagate through MemberExpr/DeclRefExpr, so any Expr of matrix type carries the attribute on its QualType. Helper becomes isMatrixRowMajor(LangOpts, QualType)
— no Decl ever needed at the call site.
Pros:
- Eliminates all walking. Every existing call site already has a QualType. Naturally survives template instantiation, auto, casts that preserve sugar.
- Matches how HLSL resource attributes are already modeled (HLSLAttributedResourceType).
Cons:
- Bigger Sema change (need to actually mutate the declared type when the attr is parsed)
- and you need a new attr::HLSLRowMajor / HLSLColumnMajor kind in Attr.td so AttributedType recognizes them.
farzonl
commented
Apr 30, 2026
| --- | ||
|
|
||
| * Discussion topics | ||
| * * Discuss SPIR-V Validator (spirv-val) failures and resolutions: |
Member
Author
There was a problem hiding this comment.
Suggested change
| * * Discuss SPIR-V Validator (spirv-val) failures and resolutions: | |
| * Constant Buffer Discussions | |
| * No Resource buffers in constant buffer | |
| * Add const? We have to allow calls to non-const. | |
| * 202y we migrate. Use clang-tidy to only allow calls to const | |
| * Discuss SPIR-V Validator (spirv-val) failures and resolutions: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This covers discussion topics known and to be added during the meeting.