Fix bitwise NOT (~) on boolean in tokenizer fallback#3845
Open
Chessing234 wants to merge 1 commit intolm-sys:mainfrom
Open
Fix bitwise NOT (~) on boolean in tokenizer fallback#3845Chessing234 wants to merge 1 commit intolm-sys:mainfrom
Chessing234 wants to merge 1 commit intolm-sys:mainfrom
Conversation
…er fallback In `load_compress_model`, the TypeError fallback path uses `~use_fast` to flip the boolean. The `~` operator is bitwise NOT, so `~True` evaluates to `-2` and `~False` to `-1`—both truthy. This means the fallback never actually toggles `use_fast`, defeating the purpose of the retry. Use `not use_fast` for correct boolean negation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
In
load_compress_model(), whenAutoTokenizer.from_pretrainedraises aTypeError, the fallback retries withuse_fast=~use_fast. The~operator is Python's bitwise NOT, not logical NOT:~True→-2(truthy)~False→-1(truthy)So the fallback never actually flips
use_fast— it always passes a truthy value, defeating the purpose of the retry.Fix
Replace
~use_fastwithnot use_fastfor correct boolean negation.Note: the analogous code in
model_adapter.py(line 116) correctly hardcodesuse_fast=Falsein its fallback, confirming the intended behavior.🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com