From 5921eedc34f1e8fa3dc7ab55b0b2e6fa3e6c301d Mon Sep 17 00:00:00 2001 From: Taksh Date: Mon, 13 Apr 2026 06:40:11 +0530 Subject: [PATCH] Fix moderation checking only left model's conversation in arena battles MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit all_conv_text_right reads from states[0] (left model) instead of states[1] (right model), so the right model's conversation is never moderation-checked. This is a copy-paste error — the named arena file (gradio_block_arena_named.py) correctly uses states[1]. Co-Authored-By: Claude Opus 4.6 (1M context) --- fastchat/serve/gradio_block_arena_anony.py | 2 +- fastchat/serve/gradio_block_arena_vision_named.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fastchat/serve/gradio_block_arena_anony.py b/fastchat/serve/gradio_block_arena_anony.py index 625c69c44..90048ead2 100644 --- a/fastchat/serve/gradio_block_arena_anony.py +++ b/fastchat/serve/gradio_block_arena_anony.py @@ -307,7 +307,7 @@ def add_text( model_list = [states[i].model_name for i in range(num_sides)] # turn on moderation in battle mode all_conv_text_left = states[0].conv.get_prompt() - all_conv_text_right = states[0].conv.get_prompt() + all_conv_text_right = states[1].conv.get_prompt() all_conv_text = ( all_conv_text_left[-1000:] + all_conv_text_right[-1000:] + "\nuser: " + text ) diff --git a/fastchat/serve/gradio_block_arena_vision_named.py b/fastchat/serve/gradio_block_arena_vision_named.py index 7c653acf3..334686773 100644 --- a/fastchat/serve/gradio_block_arena_vision_named.py +++ b/fastchat/serve/gradio_block_arena_vision_named.py @@ -242,7 +242,7 @@ def add_text( model_list = [states[i].model_name for i in range(num_sides)] all_conv_text_left = states[0].conv.get_prompt() - all_conv_text_right = states[0].conv.get_prompt() + all_conv_text_right = states[1].conv.get_prompt() all_conv_text = ( all_conv_text_left[-1000:] + all_conv_text_right[-1000:] + "\nuser: " + text )