Implement HTTP mapping of funds withdrawals

Author: lmirabal

http/src/main/kotlin/lmirabal/bank/http/BankHttp.kt

@@ -23,6 +23,7 @@ fun bankHttp() = bankHttp(BankService(InMemoryBankAccountRepository()))
 
 internal const val BANK_ACCOUNTS_BASE_URL = "/bank/accounts"
 internal const val BANK_ACCOUNT_DEPOSIT_PATH = "/{id}/deposit"
+internal const val BANK_ACCOUNT_WITHDRAWAL_PATH = "/{id}/withdraw"
 internal val bankAccountLens = Body.auto<BankAccount>().toLens()
 internal val bankAccountListLens = Body.auto<List<BankAccount>>().toLens()
 internal val accountIdLens = Path.map({ BankAccountId(UUID.fromString(it)) }, { it.value.toString() }).of("id")
@@ -40,6 +41,12 @@ internal fun bankHttp(bank: Bank): HttpHandler {
                 val amount = amountLens(request)
 
                 Response(OK).with(bankAccountLens of bank.deposit(accountId, amount))
+            },
+            BANK_ACCOUNT_WITHDRAWAL_PATH bind POST to { request ->
+                val accountId = accountIdLens(request)
+                val amount = amountLens(request)
+
+                Response(OK).with(bankAccountLens of bank.withdraw(accountId, amount))
             }
         ),
     )

http/src/main/kotlin/lmirabal/bank/http/BankHttpClient.kt

@@ -22,14 +22,18 @@ class BankHttpClient(val http: HttpHandler) : Bank {
     }
 
     override fun deposit(id: BankAccountId, amount: Amount): BankAccount {
+        return changeBalanceAction(BANK_ACCOUNT_DEPOSIT_PATH, id, amount)
+    }
+
+    override fun withdraw(id: BankAccountId, amount: Amount): BankAccount {
+        return changeBalanceAction(BANK_ACCOUNT_WITHDRAWAL_PATH, id, amount)
+    }
+
+    private fun changeBalanceAction(actionPath: String, id: BankAccountId, amount: Amount): BankAccount {
         val response = http(
-            Request(POST, BANK_ACCOUNTS_BASE_URL + BANK_ACCOUNT_DEPOSIT_PATH)
+            Request(POST, BANK_ACCOUNTS_BASE_URL + actionPath)
                 .with(accountIdLens of id, amountLens of amount)
         )
         return bankAccountLens(response)
     }
-
-    override fun withdraw(id: BankAccountId, amount: Amount): BankAccount {
-        TODO("Not yet implemented")
-    }
 }

http/src/test/kotlin/lmirabal/bank/http/BankHttpIntegrationTest.kt

@@ -9,7 +9,9 @@ import org.http4k.server.SunHttp
 import org.http4k.server.asServer
 import org.junit.jupiter.api.AfterEach
 import org.junit.jupiter.api.BeforeEach
+import org.junit.jupiter.api.Tag
 
+@Tag("ImplementationReady")
 class BankHttpIntegrationTest : BankTest() {
     private val server = bankHttp().asServer(SunHttp())
     override val bank = BankHttpClient(

http/src/test/kotlin/lmirabal/bank/http/BankHttpTest.kt

@@ -1,7 +1,9 @@
 package lmirabal.bank.http
 
 import lmirabal.bank.BankTest
+import org.junit.jupiter.api.Tag
 
+@Tag("ImplementationReady")
 class BankHttpTest : BankTest() {
     override val bank = BankHttpClient(bankHttp())
 }