Resolve #394: Replace Boost.Program_options with CLI11 (#396)

* Replace Boost.Program_options with CLI11 to resolve version pinning (#394)

- Replace boost::program_options with header-only CLI11 in main.cpp
- Remove boost dependency from Makefile, default.nix, and flake.nix
- Update documentation in doc/BUILD.md
- Add CMakeLists.txt as an alternative build system

This fixes the issue where the binary would fail to find specific libboost_program_options.so versions (e.g., 1.90.0) on systems with newer/older Boost versions. Since CLI11 is header-only, there is no longer a runtime dependency on Boost for pcloudcc.

* Update build configuration and dev scripts to remove remaining Boost references

- Remove Boost from dev scripts and container build configs
- Add -std=c++11 to Makefile CXXFLAGS
- Explicitly add -I. to Makefile CFLAGS for CLI11.hpp include

* Address build review feedback and fix security/bug issues

- Fix passascrypto logic and type (now a flag) in main.cpp
- Fix typo in daemon process name
- Add secret wiping (putil_wipe) for tfa_code and singleton passwords
- Remove redundant App setup in control_tools.cpp
- Use CLI11 envname for PCLOUD_USER
- Fix C++11 compatibility for putil_wipe and App initialization in control_tools.cpp

* Remove phantom CMakeLists.txt and ensure Makefile is the source of truth

---------

Co-authored-by: Levi Neely <lkn@darkstar.example.net>

Author: lneely

Makefile

@@ -31,11 +31,11 @@ else
 endif
 
 COMMONFLAGS	= -fsanitize=address
-CFLAGS		= -fPIC $(COMMONFLAGS) -I./pclsync -I/usr/include $(FUSE_CFLAGS) $(shell pkg-config --cflags $$(pkg-config --list-all | grep -o 'mbedtls[0-9.]*\s' | head -1) 2>/dev/null || pkg-config --cflags mbedtls 2>/dev/null || echo "-I/usr/local/include")
+CFLAGS		= -fPIC $(COMMONFLAGS) -I. -I./pclsync -I/usr/include $(FUSE_CFLAGS) $(shell pkg-config --cflags $$(pkg-config --list-all | grep -o 'mbedtls[0-9.]*\s' | head -1) 2>/dev/null || pkg-config --cflags mbedtls 2>/dev/null || echo "-I/usr/local/include")
 ifneq (,$(filter clang%,$(CC)))
     CFLAGS += -Wthread-safety
 endif
-CXXFLAGS	= $(CFLAGS)
+CXXFLAGS	= $(CFLAGS) -std=c++11
 LIBLDFLAGS	= $(COMMONFLAGS) -lreadline -lpthread -ludev -lsqlite3 -lz $(shell \
 	MBEDTLS_PKG=$$(pkg-config --list-all 2>/dev/null | grep -o 'mbedtls[0-9.]*\s' | head -1 | tr -d ' '); \
 	if [ -n "$$MBEDTLS_PKG" ]; then \
@@ -45,7 +45,7 @@ LIBLDFLAGS	= $(COMMONFLAGS) -lreadline -lpthread -ludev -lsqlite3 -lz $(shell \
 	else \
 		pkg-config --libs mbedtls mbedx509 mbedcrypto 2>/dev/null || echo "-L/usr/local/lib -lmbedtls -lmbedx509 -lmbedcrypto"; \
 	fi)
-EXECLDFLAGS	= $(COMMONFLAGS) -lboost_program_options $(FUSE_LIBS)
+EXECLDFLAGS	= $(COMMONFLAGS) $(FUSE_LIBS)
 
 SCAN		:= 0
 SRCDIR 		:= .

control_tools.cpp

@@ -198,7 +198,9 @@ void setup_app(CLI::App *app) {
     size_t errm_size = 0;
     RpcClient *rpc = new RpcClient();
     int result = rpc->Call(SENDAUTH, auth_pass_input.c_str(), &errm, &errm_size);
-    putil_wipe(auth_pass_input.data(), auth_pass_input.size());
+    if (!auth_pass_input.empty()) {
+      putil_wipe(&auth_pass_input[0], auth_pass_input.size());
+    }
     auth_pass_input.clear();
     if (result != 0) {
       std::cerr << "Failed to send auth: " << (errm ? errm : "no message") << std::endl;
@@ -221,7 +223,9 @@ void setup_app(CLI::App *app) {
     size_t errm_size = 0;
     RpcClient *rpc = new RpcClient();
     int result = rpc->Call(SENDAUTHSAVE, authsave_pass_input.c_str(), &errm, &errm_size);
-    putil_wipe(authsave_pass_input.data(), authsave_pass_input.size());
+    if (!authsave_pass_input.empty()) {
+      putil_wipe(&authsave_pass_input[0], authsave_pass_input.size());
+    }
     authsave_pass_input.clear();
     if (result != 0) {
       std::cerr << "Failed to send auth: " << (errm ? errm : "no message") << std::endl;
@@ -440,7 +444,7 @@ void setup_app(CLI::App *app) {
 }
 
 int process_command(const std::string &command) {
-  CLI::App app = CLI::App{"pcloudcc-lneely"};
+  CLI::App app{"pcloudcc-lneely"};
   setup_app(&app);
   try {
     app.parse(command);
@@ -480,9 +484,6 @@ int process_command(const std::string &command) {
 }
 
 void process_commands() {
-  CLI::App app = CLI::App{"pcloudcc-lneely"};
-  setup_app(&app);
-
   using_history();
   rl_attempted_completion_function = command_completion;
 

default.nix

@@ -5,7 +5,6 @@ pkgs.mkShell {
   buildInputs = with pkgs; [
     zlib
     sqlite
-    boost
     libudev-zero
     readline
     fuse
@@ -15,15 +14,13 @@ pkgs.mkShell {
   CFLAGS = [
     "-I${pkgs.zlib.dev}/include"
     "-I${pkgs.sqlite.dev}/include"
-    "-I${pkgs.boost.dev}/include"
     "-I${pkgs.readline.dev}/include"
     "-I${pkgs.fuse.dev}/include"
     "-I${pkgs.mbedtls}/include"
   ];
   CXXFLAGS = [
     "-I${pkgs.zlib.dev}/include"
     "-I${pkgs.sqlite.dev}/include"
-    "-I${pkgs.boost.dev}/include"
     "-I${pkgs.readline.dev}/include"
     "-I${pkgs.fuse.dev}/include"
     "-I${pkgs.mbedtls}/include"

dev/container-build.sh

@@ -93,26 +93,26 @@ case $IMAGE in
         echo "Setting up Debian/Ubuntu-based container..."
         ctrid=$(buildah from "$FULL_IMAGE")
         buildah run "$ctrid" -- apt update
-        buildah run "$ctrid" -- apt install -y build-essential git libfuse-dev libudev-dev libsqlite3-dev libmbedtls-dev zlib1g-dev libboost-system-dev libboost-program-options-dev fuse llvm gdb
+        buildah run "$ctrid" -- apt install -y build-essential git libfuse-dev libudev-dev libsqlite3-dev libmbedtls-dev zlib1g-dev fuse llvm gdb
         ;;
     fedora)
         echo "Setting up Fedora-based container..."
         ctrid=$(buildah from "$FULL_IMAGE")
         buildah run "$ctrid" -- dnf update -y
         buildah run "$ctrid" -- dnf group install -y "C Development Tools and Libraries"
-        buildah run "$ctrid" -- dnf install -y git fuse-devel systemd-devel sqlite-devel mbedtls-devel zlib-devel boost-devel boost-program-options fuse llvm gdb fuse udev libasan
+        buildah run "$ctrid" -- dnf install -y git fuse-devel systemd-devel sqlite-devel mbedtls-devel zlib-devel fuse llvm gdb fuse udev libasan
         ;;
     archlinux|arch)
         echo "Setting up Arch Linux-based container..."
         ctrid=$(buildah from "$FULL_IMAGE")
         buildah run "$ctrid" -- pacman -Syu --noconfirm
-        buildah run "$ctrid" -- pacman -S --noconfirm base-devel git fuse2 systemd sqlite mbedtls2 zlib boost boost-libs llvm gdb udev gcc make
+        buildah run "$ctrid" -- pacman -S --noconfirm base-devel git fuse2 systemd sqlite mbedtls2 zlib llvm gdb udev gcc make
         ;;
     opensuse/tumbleweed|opensuse/leap)
         echo "Setting up openSUSE-based container..."
         ctrid=$(buildah from "$FULL_IMAGE")
         buildah run "$ctrid" -- zypper refresh
-        buildah run "$ctrid" -- zypper install -y gcc gcc-c++ make git fuse-devel systemd-devel sqlite3-devel zlib-devel libboost_system-devel libboost_program_options-devel fuse llvm gdb udev mbedtls-2-devel
+        buildah run "$ctrid" -- zypper install -y gcc gcc-c++ make git fuse-devel systemd-devel sqlite3-devel zlib-devel fuse llvm gdb udev mbedtls-2-devel
         ;;
     *)
         echo "Unsupported image: $IMAGE"

dev/devhost-arch-arm64.sh

@@ -103,7 +103,7 @@ build_container() {
         sudo vim nano curl wget git htop tmux man-db \
         bash-completion ca-certificates openssh \
         base-devel gcc gcc-libs make fuse2 systemd sqlite3 \
-        mbedtls zlib boost llvm gdb iproute \
+        mbedtls zlib llvm gdb iproute \
         rsync readline
 
     # verify fuse

dev/devhost-arch.sh

@@ -103,7 +103,7 @@ build_container() {
         sudo vim nano curl wget git htop tmux man-db \
         bash-completion ca-certificates openssh \
         base-devel gcc gcc-libs make fuse2 systemd sqlite3 \
-        mbedtls zlib boost llvm gdb iproute \
+        mbedtls zlib llvm gdb iproute \
         rsync readline
 
     # verify fuse

dev/devhost-debian.sh

@@ -106,8 +106,7 @@ build_container() {
         sudo vim nano curl wget git htop tmux man-db locales \
         bash-completion ca-certificates ssh systemd systemd-sysv \
         build-essential libfuse-dev libudev-dev libsqlite3-dev \
-        libmbedtls-dev zlib1g-dev libboost-system-dev \
-        libboost-program-options-dev fuse llvm gdb iproute2 \
+        libmbedtls-dev zlib1g-dev fuse llvm gdb iproute2 \
         openssh-server rsync libreadline-dev
 
     # verify fuse

dev/devhost-fedora.sh

@@ -103,7 +103,7 @@ build_container() {
         sudo vim nano curl wget git htop tmux man-db \
         bash-completion ca-certificates openssh-server \
         gcc gcc-c++ make fuse-devel systemd-devel sqlite-devel \
-        mbedtls-devel zlib-devel boost-devel fuse llvm gdb iproute \
+        mbedtls-devel zlib-devel fuse llvm gdb iproute \
         rsync readline-devel
 
     # verify fuse

doc/BUILD.md

@@ -1,6 +1,6 @@
 # Dependencies
 - zlib (-lz)
-- boost (-lboost_system, -lboost_program_options)
+- CLI11 (included as CLI11.hpp)
 - pthread (lpthread)
 - udev (-ludev)
 - fuse (-lfuse)

flake.nix

@@ -16,7 +16,6 @@
             clang-tools
             zlib
             sqlite
-            boost
             libudev-zero
             readline
             fuse
@@ -27,7 +26,6 @@
           CFLAGS = [
             "-I${pkgs.zlib.dev}/include"
             "-I${pkgs.sqlite.dev}/include"
-            "-I${pkgs.boost.dev}/include"
             "-I${pkgs.readline.dev}/include"
             "-I${pkgs.fuse.dev}/include"
             "-I${pkgs.mbedtls}/include"
@@ -36,7 +34,6 @@
           CXXFLAGS = [
             "-I${pkgs.zlib.dev}/include"
             "-I${pkgs.sqlite.dev}/include"
-            "-I${pkgs.boost.dev}/include"
             "-I${pkgs.readline.dev}/include"
             "-I${pkgs.fuse.dev}/include"
             "-I${pkgs.mbedtls}/include"