Skip to content

Some typo and bug fix#35

Open
peacedog123 wants to merge 1 commit into
lni:masterfrom
peacedog123:master
Open

Some typo and bug fix#35
peacedog123 wants to merge 1 commit into
lni:masterfrom
peacedog123:master

Conversation

@peacedog123
Copy link
Copy Markdown

Fix inconsistency of flags in multigroup example
Fix NodeHost.Stop() called twice problem

  1. In the README.md
    The command has changed to ./example-multigroup -replicaid 1, so here change the code to make it consistent between code and README.md file.

  2. When we input exit in the console, we will hit NodeHost.Stop() called twice panic like below:

exit
panic: NodeHost.Stop called twice

goroutine 1 [running]:
github.com/lni/dragonboat/v4.(*NodeHost).Close(0xc0001bea80)
        /<home-dir>/go/pkg/mod/github.com/lni/dragonboat/v4@v4.0.0-20230917160253-d9f49378cd2d/nodehost.go:390 +0x9d0
main.main()
        /<git-repo>/dragonboat-example/multigroup/main.go:195 +0x88c

Fix NodeHost.Stop called twice problem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant