Skip to content

Fix/cancelall pending only #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grunch merged 2 commits into from
Jun 30, 2026
Merged

Fix/cancelall pending only #848

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7b6eaa
fix: cancelall only cancels pending orders without blocking on in-pro…
Matobi98 Jun 26, 2026
a996f1b
fix: bail out of cancelall when pending orders fetch fails
Matobi98 Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 9 additions & 25 deletions bot/start.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,38 +502,22 @@ const initialize = (
// pending orders are the ones that are not taken by another user
bot.command('cancelall', userMiddleware, async (ctx: CommunityContext) => {
try {
const pending_orders =
(await ordersActions.getOrders(ctx.user, 'PENDING')) || [];
const seller_orders =
(await ordersActions.getOrders(ctx.user, 'WAITING_BUYER_INVOICE')) ||
[];
const buyer_orders =
(await ordersActions.getOrders(ctx.user, 'WAITING_PAYMENT')) || [];
// /cancelall only cancels PENDING orders (published orders that nobody
// has taken yet). Orders already being taken (WAITING_PAYMENT /
// WAITING_BUYER_INVOICE) must be handled individually with /cancel or
// through a dispute, just like single /cancel rejects them.
const orders = await ordersActions.getOrders(ctx.user, 'PENDING');

const orders = [...pending_orders, ...seller_orders, ...buyer_orders];
// getOrders returns undefined when the query itself failed (already
// logged). Bail out instead of telling the user they have no orders,
// which would otherwise leave their pending orders silently uncanceled.
if (orders === undefined) return;

if (orders.length === 0) {
return await messages.notOrdersMessage(ctx);
}

for (const order of orders) {
// If a buyer is taking a sell offer and accidentally touch continue button we
// let the user to cancel
if (order.type === 'sell' && order.status === 'WAITING_BUYER_INVOICE') {
return await cancelAddInvoice(ctx, order);
}

// If a seller is taking a buy offer and accidentally touch continue button we
// let the user to cancel
if (order.type === 'buy' && order.status === 'WAITING_PAYMENT') {
return await cancelShowHoldInvoice(ctx, order);
}

// If a buyer wants cancel but the seller already pay the hold invoice
if (order.type === 'buy' && order.status === 'WAITING_BUYER_INVOICE') {
if (order.hash) await cancelHoldInvoice({ hash: order.hash });
}

order.status = 'CANCELED';
order.canceled_by = ctx.user.id;
await order.save();
Expand Down
Loading