Skip to content

Enhancement: Declare test code in separate directories with separate configuration files#7

Open
localheinz wants to merge 1 commit into
mainfrom
feature/separate-directories-with-separate-configuration-files
Open

Enhancement: Declare test code in separate directories with separate configuration files#7
localheinz wants to merge 1 commit into
mainfrom
feature/separate-directories-with-separate-configuration-files

Conversation

@localheinz
Copy link
Copy Markdown
Owner

This pull request

  • declares test code in subdirectories of test/ with separate configuration files

@localheinz localheinz requested a review from ergebnis-bot as a code owner March 3, 2023 08:41
@localheinz localheinz self-assigned this Mar 3, 2023
@localheinz localheinz force-pushed the feature/separate-directories-with-separate-configuration-files branch 5 times, most recently from 98a35f1 to f851116 Compare March 3, 2023 09:56
Comment thread .gitattributes
@@ -1,5 +1,6 @@
/.github/ export-ignore
/.phive/ export-ignore
/test/ export-ignore
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you work on a package and declare test code in separate directories with separate configuration files, adding exclusions for test code in .gitattributes is less work.

There is no need to add configuration files as they are in the excluded directory.

Comment thread composer.json
Comment on lines +39 to +43
"autoload-dev": {
"psr-4": {
"Localheinz\\OrganizingTestCodeInPhp\\Test\\": "test/"
}
},
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you declare test code in separate directories with separate configuration files, managing exclusions for the composer autoloader in composer.json is unnecessary. Instead, you configure and document namespaces for test code via an autoloader configuration in the autoload-dev section.

Comment thread infection.json
Comment on lines +11 to +15
"source": {
"directories": [
"src"
]
},
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you declare test code in separate directories with separate configuration files, managing exclusions for infection/infection in infection.json is unnecessary.

Comment thread test/Unit/phpunit.xml Outdated
Comment on lines +28 to +30
<include>
<directory suffix=".php">../../src/</directory>
</include>
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you declare test code in separate directories with separate configuration files, managing exclusions for collecting code coverage with phpunit/phpunit in phpunit.xml is unnecessary.

@localheinz localheinz force-pushed the feature/separate-directories-with-separate-configuration-files branch 2 times, most recently from bcaa6e7 to f4aee49 Compare September 20, 2023 11:24
@localheinz localheinz force-pushed the feature/separate-directories-with-separate-configuration-files branch from f4aee49 to 221c550 Compare January 2, 2024 11:25
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 2, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@d732079). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff            @@
##             main        #7   +/-   ##
========================================
  Coverage        ?   100.00%           
  Complexity      ?         8           
========================================
  Files           ?         3           
  Lines           ?        16           
  Branches        ?         0           
========================================
  Hits            ?        16           
  Misses          ?         0           
  Partials        ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@localheinz localheinz force-pushed the feature/separate-directories-with-separate-configuration-files branch from 221c550 to 8e33611 Compare January 2, 2024 11:26
@localheinz localheinz force-pushed the feature/separate-directories-with-separate-configuration-files branch from 8e33611 to c4165fb Compare January 2, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants