Skip to content

align s3-static-website sample with docs tutorial and rename deprecated path-style flag #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HarshCasper merged 3 commits into from
Apr 27, 2026
+10 −28
Merged

align s3-static-website sample with docs tutorial and rename deprecated path-style flag #15

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
287bc55
fix: replace deprecated s3_force_path_style with s3_use_path_style in…
HarshCasper Mar 16, 2026
314ac96
fixes
HarshCasper Apr 27, 2026
5f31ba9
fixes
HarshCasper Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 5 additions & 24 deletions s3-static-website/provider.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,34 +2,15 @@ provider "aws" {
access_key = "test"
secret_key = "test"
region = "us-east-1"
s3_force_path_style = false

# only required for non virtual hosted-style endpoint use case.
# https://registry.terraform.io/providers/hashicorp/aws/latest/docs#s3_force_path_style
s3_use_path_style = true
skip_credentials_validation = true
skip_metadata_api_check = true
skip_requesting_account_id = true

endpoints {
apigateway = "http://localhost:4566"
Copy link
Copy Markdown

@remotesynth remotesynth Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, wasn't it just removing the s3_force_path_style? Are all these endpoints unnecessary now too? I really don't know just confirming

Copy link
Copy Markdown
Member Author

@HarshCasper HarshCasper Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The endpoints were unused. This sample only uses S3, so the rest were dead config. The s3control endpoint is the one new endpoint we do need (newer AWS provider versions read bucket tags via S3 Control).

apigatewayv2 = "http://localhost:4566"
cloudformation = "http://localhost:4566"
cloudwatch = "http://localhost:4566"
dynamodb = "http://localhost:4566"
ec2 = "http://localhost:4566"
es = "http://localhost:4566"
elasticache = "http://localhost:4566"
firehose = "http://localhost:4566"
iam = "http://localhost:4566"
kinesis = "http://localhost:4566"
lambda = "http://localhost:4566"
rds = "http://localhost:4566"
redshift = "http://localhost:4566"
route53 = "http://localhost:4566"
s3 = "http://s3.localhost.localstack.cloud:4566"
secretsmanager = "http://localhost:4566"
ses = "http://localhost:4566"
sns = "http://localhost:4566"
sqs = "http://localhost:4566"
ssm = "http://localhost:4566"
stepfunctions = "http://localhost:4566"
sts = "http://localhost:4566"
s3control = "http://localhost.localstack.cloud:4566"
}
}