Fix pre-existing CI failures on the snowflake branch lineage

Wojciech Padlo · claude · Wojciech Padlo · commit 855bcd95db94 · 2026-06-08T16:25:09.000+02:00
These checks were already red on the base branch (lav-379-2-for-over-cursor),
inherited from the cursor/scripting/ACCOUNT commits — unrelated to ALTER STAGE,
but required for green CI on this PR:

- codestyle: run cargo fmt --all across the crate
- lint: collapse a match-in-match (parser scripting list), replace a forbidden
  unreachable! in DESCRIBE object-type parsing with a parse error, and collapse
  nested match arms in the warehouse/account tests
- docs: drop unresolved intra-doc link brackets in scripting-list doc comments
- compile-no-std: gate 'use alloc::vec' behind not(feature = std) in spans.rs

Co-Authored-By: Claude Opus 4.8 &lt;noreply@anthropic.com&gt;
diff --git a/src/ast/mod.rs b/src/ast/mod.rs
@@ -7024,18 +7024,10 @@ impl fmt::Display for Statement {
                 }
                 write!(f, ")")?;
                 if let Some(val) = allow_writes {
-                    write!(
-                        f,
-                        " ALLOW_WRITES = {}",
-                        if *val { "TRUE" } else { "FALSE" }
-                    )?;
+                    write!(f, " ALLOW_WRITES = {}", if *val { "TRUE" } else { "FALSE" })?;
                 }
                 if let Some(ref c) = comment {
-                    write!(
-                        f,
-                        " COMMENT = '{}'",
-                        value::escape_single_quote_string(c)
-                    )?;
+                    write!(f, " COMMENT = '{}'", value::escape_single_quote_string(c))?;
                 }
                 Ok(())
             }
@@ -7163,20 +7155,12 @@ impl fmt::Display for Statement {
                 if let Some(ref auth) = rest_authentication {
                     write!(f, " REST_AUTHENTICATION = ({auth})")?;
                 }
-                write!(
-                    f,
-                    " ENABLED = {}",
-                    if *enabled { "TRUE" } else { "FALSE" }
-                )?;
+                write!(f, " ENABLED = {}", if *enabled { "TRUE" } else { "FALSE" })?;
                 if let Some(secs) = refresh_interval_seconds {
                     write!(f, " REFRESH_INTERVAL_SECONDS = {secs}")?;
                 }
                 if let Some(ref c) = comment {
-                    write!(
-                        f,
-                        " COMMENT = '{}'",
-                        value::escape_single_quote_string(c)
-                    )?;
+                    write!(f, " COMMENT = '{}'", value::escape_single_quote_string(c))?;
                 }
                 Ok(())
             }
@@ -12466,11 +12450,7 @@ impl fmt::Display for CatalogRestConfig {
             write!(f, " CATALOG_API_TYPE = {t}")?;
         }
         if let Some(ref w) = self.warehouse {
-            write!(
-                f,
-                " WAREHOUSE = '{}'",
-                value::escape_single_quote_string(w)
-            )?;
+            write!(f, " WAREHOUSE = '{}'", value::escape_single_quote_string(w))?;
         }
         if let Some(ref m) = self.access_delegation_mode {
             write!(f, " ACCESS_DELEGATION_MODE = {m}")?;
diff --git a/src/ast/spans.rs b/src/ast/spans.rs
@@ -23,6 +23,8 @@ use crate::{
     },
     tokenizer::TokenWithSpan,
 };
+#[cfg(not(feature = "std"))]
+use alloc::vec;
 use core::iter;
 
 use crate::tokenizer::Span;
@@ -35,20 +37,19 @@ use super::{
     ConflictTarget, ConnectByKind, ConstraintCharacteristics, CopySource, CreateIndex, CreateTable,
     CreateTableOptions, Cte, Delete, DoUpdate, ExceptSelectItem, ExcludeSelectItem, Expr,
     ExprWithAlias, Fetch, ForIterationSource, ForStatement, ForValues, FromTable, Function,
-    FunctionArg,
-    FunctionArgExpr, FunctionArgumentClause, FunctionArgumentList, FunctionArguments, GroupByExpr,
-    HavingBound, IfStatement, IlikeSelectItem, IndexColumn, Insert, Interpolate, InterpolateExpr,
-    Join, JoinConstraint, JoinOperator, JsonPath, JsonPathElem, LateralView, LimitClause,
-    LoopControlStatement, LoopStatement, MatchRecognizePattern, Measure, Merge, MergeAction,
-    MergeClause, MergeInsertExpr, MergeInsertKind, MergeUpdateExpr, NamedParenthesizedList,
-    NamedWindowDefinition, ObjectName, ObjectNamePart, Offset, OnConflict, OnConflictAction,
-    OnInsert, OpenStatement, OrderBy, OrderByExpr, OrderByKind, OutputClause, Parens, Partition,
-    PartitionBoundValue, PivotValueSource, ProjectionSelect, Query, RaiseStatement,
-    RaiseStatementValue, ReferentialAction, RenameSelectItem, RepeatStatement, ReplaceSelectElement,
-    ReplaceSelectItem, Select, SelectInto, SelectItem, SetExpr, SqlOption, Statement, Subscript,
-    SymbolDefinition, TableAlias, TableAliasColumnDef, TableConstraint, TableFactor, TableObject,
-    TableOptionsClustered, TableWithJoins, Update, UpdateTableFromKind, Use, Values, ViewColumnDef,
-    WhileStatement, WildcardAdditionalOptions, With, WithFill,
+    FunctionArg, FunctionArgExpr, FunctionArgumentClause, FunctionArgumentList, FunctionArguments,
+    GroupByExpr, HavingBound, IfStatement, IlikeSelectItem, IndexColumn, Insert, Interpolate,
+    InterpolateExpr, Join, JoinConstraint, JoinOperator, JsonPath, JsonPathElem, LateralView,
+    LimitClause, LoopControlStatement, LoopStatement, MatchRecognizePattern, Measure, Merge,
+    MergeAction, MergeClause, MergeInsertExpr, MergeInsertKind, MergeUpdateExpr,
+    NamedParenthesizedList, NamedWindowDefinition, ObjectName, ObjectNamePart, Offset, OnConflict,
+    OnConflictAction, OnInsert, OpenStatement, OrderBy, OrderByExpr, OrderByKind, OutputClause,
+    Parens, Partition, PartitionBoundValue, PivotValueSource, ProjectionSelect, Query,
+    RaiseStatement, RaiseStatementValue, ReferentialAction, RenameSelectItem, RepeatStatement,
+    ReplaceSelectElement, ReplaceSelectItem, Select, SelectInto, SelectItem, SetExpr, SqlOption,
+    Statement, Subscript, SymbolDefinition, TableAlias, TableAliasColumnDef, TableConstraint,
+    TableFactor, TableObject, TableOptionsClustered, TableWithJoins, Update, UpdateTableFromKind,
+    Use, Values, ViewColumnDef, WhileStatement, WildcardAdditionalOptions, With, WithFill,
 };
 
 /// Given an iterator of spans, return the [Span::union] of all spans.
@@ -832,10 +833,7 @@ impl Spanned for RepeatStatement {
 impl Spanned for LoopControlStatement {
     fn span(&self) -> Span {
         let LoopControlStatement { kind: _, label } = self;
-        label
-            .as_ref()
-            .map(|l| l.span)
-            .unwrap_or_else(Span::empty)
+        label.as_ref().map(|l| l.span).unwrap_or_else(Span::empty)
     }
 }
 
diff --git a/src/dialect/snowflake.rs b/src/dialect/snowflake.rs
@@ -28,16 +28,16 @@ use crate::ast::helpers::stmt_data_loading::{
 };
 use crate::ast::{
     AlterExternalVolumeOperation, AlterFileFormatOperation, AlterStageOperation, AlterTable,
-    AlterTableOperation, AlterTableType,
-    CatalogRestAuthentication, CatalogRestConfig, CatalogSource, CatalogSyncNamespaceMode,
-    CatalogTableFormat, ColumnOption, ColumnPolicy, ColumnPolicyProperty, ContactEntry,
-    CopyIntoSnowflakeKind, CreateTable, CreateTableLikeKind, DollarQuotedString,
-    ExternalVolumeEncryption, ExternalVolumeStorageLocation, Ident, IdentityParameters,
-    IdentityProperty, IdentityPropertyFormatKind, IdentityPropertyKind, IdentityPropertyOrder,
-    InitializeKind, Insert, MultiTableInsertIntoClause, MultiTableInsertType, MultiTableInsertValue,
-    MultiTableInsertValues, MultiTableInsertWhenClause, ObjectName, ObjectNamePart,
-    RefreshModeKind, RowAccessPolicy, ShowObjects, SqlOption, Statement, StorageLifecyclePolicy,
-    StorageSerializationPolicy, TableObject, TagsColumnOption, Value, WrappedCollection,
+    AlterTableOperation, AlterTableType, CatalogRestAuthentication, CatalogRestConfig,
+    CatalogSource, CatalogSyncNamespaceMode, CatalogTableFormat, ColumnOption, ColumnPolicy,
+    ColumnPolicyProperty, ContactEntry, CopyIntoSnowflakeKind, CreateTable, CreateTableLikeKind,
+    DollarQuotedString, ExternalVolumeEncryption, ExternalVolumeStorageLocation, Ident,
+    IdentityParameters, IdentityProperty, IdentityPropertyFormatKind, IdentityPropertyKind,
+    IdentityPropertyOrder, InitializeKind, Insert, MultiTableInsertIntoClause,
+    MultiTableInsertType, MultiTableInsertValue, MultiTableInsertValues,
+    MultiTableInsertWhenClause, ObjectName, ObjectNamePart, RefreshModeKind, RowAccessPolicy,
+    ShowObjects, SqlOption, Statement, StorageLifecyclePolicy, StorageSerializationPolicy,
+    TableObject, TagsColumnOption, Value, WrappedCollection,
 };
 use crate::dialect::{Dialect, Precedence};
 use crate::keywords::Keyword;
@@ -319,7 +319,10 @@ impl Dialect for SnowflakeDialect {
             return Some(parse_drop_file_format(parser));
         }
 
-        if parser.parse_one_of_keywords(&[Keyword::DESC, Keyword::DESCRIBE]).is_some() {
+        if parser
+            .parse_one_of_keywords(&[Keyword::DESC, Keyword::DESCRIBE])
+            .is_some()
+        {
             if parser.parse_keywords(&[Keyword::EXTERNAL, Keyword::VOLUME]) {
                 // DESC[RIBE] EXTERNAL VOLUME
                 return Some(parse_describe_external_volume(parser));
@@ -2206,9 +2209,7 @@ fn parse_external_volume_storage_location(
     }
 
     let storage_base_url = storage_base_url.ok_or_else(|| {
-        ParserError::ParserError(
-            "STORAGE_BASE_URL is required in STORAGE_LOCATION".to_string(),
-        )
+        ParserError::ParserError("STORAGE_BASE_URL is required in STORAGE_LOCATION".to_string())
     })?;
 
     Ok(ExternalVolumeStorageLocation {
@@ -2316,7 +2317,8 @@ fn parse_create_file_format(
     }
 
     // `LIKE` is mutually exclusive with `TYPE`/options per Snowflake's grammar.
-    if like_source.is_some() && !matches!(parser.peek_token().token, Token::EOF | Token::SemiColon) {
+    if like_source.is_some() && !matches!(parser.peek_token().token, Token::EOF | Token::SemiColon)
+    {
         return parser.expected(
             "end of statement after CREATE FILE FORMAT ... LIKE",
             parser.peek_token(),
diff --git a/src/parser/mod.rs b/src/parser/mod.rs
@@ -979,7 +979,8 @@ impl<'a> Parser<'a> {
             }
         };
 
-        let conditional_statements = self.parse_scripting_conditional_statements(terminal_keywords)?;
+        let conditional_statements =
+            self.parse_scripting_conditional_statements(terminal_keywords)?;
 
         Ok(ConditionalStatementBlock {
             start_token: AttachedToken(start_token),
@@ -1013,13 +1014,13 @@ impl<'a> Parser<'a> {
         Ok(conditional_statements)
     }
 
-    /// Like [`parse_conditional_statements`], but the bare-sequence branch
-    /// dispatches to [`parse_scripting_statement_list`] so that body-only
+    /// Like `parse_conditional_statements`, but the bare-sequence branch
+    /// dispatches to `parse_scripting_statement_list` so that body-only
     /// scripting forms (loop control, `LET`, bare assignment) parse when the
     /// body omits an inner `BEGIN … END`. Used by Snowflake-scripting loop
     /// and conditional constructs; **not** used by `CREATE TRIGGER` /
     /// `CREATE PROCEDURE` bodies, which retain their existing semantics via
-    /// [`parse_conditional_statements`].
+    /// `parse_conditional_statements`.
     fn parse_scripting_conditional_statements(
         &mut self,
         terminal_keywords: &[Keyword],
@@ -1042,7 +1043,7 @@ impl<'a> Parser<'a> {
 
     /// Parse a list of statements inside a `BEGIN...END` scripting block.
     ///
-    /// Extends [`parse_statement_list`] with Snowflake-scripting-specific forms:
+    /// Extends `parse_statement_list` with Snowflake-scripting-specific forms:
     /// - Bare assignment: `var := expr`
     /// - `LET` declaration: `LET var [data_type] := expr`
     pub(crate) fn parse_scripting_statement_list(
@@ -1053,10 +1054,10 @@ impl<'a> Parser<'a> {
         loop {
             match &self.peek_nth_token_ref(0).token {
                 Token::EOF => break,
-                Token::Word(w) => {
-                    if w.quote_style.is_none() && terminal_keywords.contains(&w.keyword) {
-                        break;
-                    }
+                Token::Word(w)
+                    if w.quote_style.is_none() && terminal_keywords.contains(&w.keyword) =>
+                {
+                    break
                 }
                 _ => {}
             }
@@ -8160,12 +8161,7 @@ impl<'a> Parser<'a> {
                             // The word could be a variable name.  Check that the token
                             // after it looks like the rest of a declaration (type, `:=`,
                             // `DEFAULT`, or `;` for a bare declaration with no type/init).
-                            matches!(
-                                tok1,
-                                Token::Assignment
-                                    | Token::Word(_)
-                                    | Token::SemiColon
-                            )
+                            matches!(tok1, Token::Assignment | Token::Word(_) | Token::SemiColon)
                         }
                         _ => false,
                     }
@@ -11476,10 +11472,7 @@ impl<'a> Parser<'a> {
             })?;
             AlterAccountOperation::Set { params }
         } else {
-            return self.expected(
-                "SET or RENAME TO after ALTER ACCOUNT",
-                self.peek_token(),
-            );
+            return self.expected("SET or RENAME TO after ALTER ACCOUNT", self.peek_token());
         };
 
         Ok(Statement::AlterAccount { name, operation })
@@ -12684,8 +12677,7 @@ impl<'a> Parser<'a> {
             let peek_token = parser.peek_token();
             let span = peek_token.span;
             match peek_token.token {
-                Token::DollarQuotedString(s)
-                    if dialect_of!(parser is PostgreSqlDialect | GenericDialect | SnowflakeDialect) =>
+                Token::DollarQuotedString(s) if dialect_of!(parser is PostgreSqlDialect | GenericDialect | SnowflakeDialect) =>
                 {
                     parser.next_token();
                     Ok(Expr::Value(Value::DollarQuotedString(s).with_span(span)))
@@ -14493,7 +14485,10 @@ impl<'a> Parser<'a> {
 
                 // Snowflake-style: DESC <object_type> <name>
                 if self.dialect.describe_requires_table_keyword()
-                    && matches!(describe_alias, DescribeAlias::Desc | DescribeAlias::Describe)
+                    && matches!(
+                        describe_alias,
+                        DescribeAlias::Desc | DescribeAlias::Describe
+                    )
                 {
                     if let Some(kw) = self.parse_one_of_keywords(&[
                         Keyword::TABLE,
@@ -14508,7 +14503,7 @@ impl<'a> Parser<'a> {
                             Keyword::DATABASE => DescribeObjectType::Database,
                             Keyword::SCHEMA => DescribeObjectType::Schema,
                             Keyword::TASK => DescribeObjectType::Task,
-                            _ => unreachable!(),
+                            _ => return self.expected("a describe object type", self.peek_token()),
                         };
                         let object_name = self.parse_object_name(false)?;
                         return Ok(Statement::DescribeObject {
diff --git a/tests/sqlparser_snowflake.rs b/tests/sqlparser_snowflake.rs
