Fix Terraform type mismatches, broken README link, and undefined variable

Agent-Logs-Url: https://github.com/localstack/localstack-azure-samples/sessions/406e9650-f8ef-48d0-875c-d862428b657f

Co-authored-by: paolosalvatori <1658419+paolosalvatori@users.noreply.github.com>

Author: Copilot

samples/web-app-custom-image/python/README.md

@@ -28,7 +28,8 @@ The solution is composed of the following Azure resources:
 
 - [Azure Subscription](https://azure.microsoft.com/free/)
 - [Azure CLI](https://learn.microsoft.com/en-us/cli/azure/install-azure-cli)
-- [Docker](https://docs.docker.com/get-docker/)udio.com/items?itemName=ms-azuretools.vscode-bicep), if you plan to install the sample via Bicep.
+- [Docker](https://docs.docker.com/get-docker/)
+- [Bicep](https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-bicep), if you plan to install the sample via Bicep.
 - [Terraform](https://developer.hashicorp.com/terraform/downloads), if you plan to install the sample via Terraform.
 - [Azlocal CLI](https://azure.localstack.cloud/user-guides/sdks/az/): LocalStack Azure CLI wrapper
 - [jq](https://jqlang.org/): JSON processor for scripting and parsing command outputs

samples/web-app-custom-image/python/scripts/deploy.sh

@@ -168,8 +168,7 @@ if [[ $? != 0 ]]; then
 	az identity create \
 		--name "$MANAGED_IDENTITY_NAME" \
 		--resource-group "$RESOURCE_GROUP_NAME" \
-		--location "$LOCATION" \
-		--subscription "$SUBSCRIPTION_ID" 1>/dev/null
+		--location "$LOCATION" 1>/dev/null
 
 	if [[ $? == 0 ]]; then
 		echo "[$MANAGED_IDENTITY_NAME] user-assigned managed identity successfully created in the [$RESOURCE_GROUP_NAME] resource group"

samples/web-app-custom-image/python/terraform/modules/log_analytics/main.tf

@@ -4,7 +4,7 @@ resource "azurerm_log_analytics_workspace" "example" {
   resource_group_name = var.resource_group_name
   sku                 = var.sku
   tags                = var.tags
-  retention_in_days   = var.retention_in_days != "" ? var.retention_in_days : null
+  retention_in_days   = var.retention_in_days != null ? var.retention_in_days : null
 
   lifecycle {
     ignore_changes = [

samples/web-app-custom-image/python/terraform/modules/private_endpoint/main.tf

@@ -9,7 +9,7 @@ resource "azurerm_private_endpoint" "example" {
     name                           = "${var.name}Connection"
     private_connection_resource_id = var.private_connection_resource_id
     is_manual_connection           = var.is_manual_connection
-    subresource_names              = try([var.subresource_name], null)
+    subresource_names              = var.subresource_name != null ? [var.subresource_name] : null
     request_message                = try(var.request_message, null)
   }
 

samples/web-app-custom-image/python/terraform/modules/private_endpoint/variables.tf

@@ -25,7 +25,7 @@ variable "subnet_id" {
 
 variable "is_manual_connection" {
   description = "(Optional) Specifies whether the Azure Private Endpoint connection requires manual approval from the remote resource owner."
-  type        = string
+  type        = bool
   default     = false
 }