Skip to content

Commit 1ea5a8c

Browse files
whummerclaude
andcommitted
fix: use full branch name for miniflare extension install in CI
GITHUB_HEAD_REF##*/ strips everything up to the last slash, turning fix/ci-failures into ci-failures which is not a valid branch ref. Use the full branch name instead. Also add --fail to the curl check so the step actually fails when the extension is not loaded. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 81b45e8 commit 1ea5a8c

1 file changed

Lines changed: 3 additions & 4 deletions

File tree

.github/workflows/miniflare.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,16 +34,15 @@ jobs:
3434
sudo apt-get install -y libvirt-dev
3535
pip install localstack localstack-ext
3636
37-
branchName=${GITHUB_HEAD_REF##*/}
38-
if [ "$branchName" = "" ]; then branchName=main; fi
37+
branchName=${GITHUB_HEAD_REF:-main}
3938
echo "Installing from branch name $branchName"
4039
localstack extensions init
41-
localstack extensions install "git+https://github.com/localstack/localstack-extensions.git@"$branchName"#egg=localstack-extension-miniflare&subdirectory=miniflare"
40+
localstack extensions install "git+https://github.com/localstack/localstack-extensions.git@${branchName}#egg=localstack-extension-miniflare&subdirectory=miniflare"
4241
4342
DEBUG=1 localstack start -d
4443
localstack wait
4544
curl http://localhost:4566/_localstack/health
46-
curl http://localhost:4566/miniflare/user
45+
curl --fail http://localhost:4566/miniflare/user
4746
4847
- name: Run test
4948
env:

0 commit comments

Comments
 (0)