Skip to content

Commit 2cba782

Browse files
committed
tmp commit to trigger error
1 parent 47715b1 commit 2cba782

File tree

2 files changed

+22
-18
lines changed

2 files changed

+22
-18
lines changed

paradedb/localstack_paradedb/extension.py

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
import socket
33

44
from localstack_extensions.utils.docker import ProxiedDockerContainerExtension
5-
from localstack.extensions.api import http
65
from localstack import config
76

87
# Environment variables for configuration
@@ -57,21 +56,22 @@ def _tcp_health_check():
5756
tcp_ports=[postgres_port], # Enable TCP proxying through gateway
5857
)
5958

60-
def update_gateway_routes(self, router: http.Router[http.RouteHandler]):
61-
"""
62-
Override to set up only TCP routing without HTTP proxy.
63-
64-
ParadeDB uses the native PostgreSQL wire protocol (not HTTP), so we
65-
only need TCP protocol routing - not HTTP proxying. Adding an HTTP
66-
proxy without a host restriction would cause all HTTP requests to be
67-
forwarded to the PostgreSQL container, breaking other services.
68-
"""
69-
# Start the container
70-
self.start_container()
71-
72-
# Set up only TCP protocol routing (skip HTTP proxy from base class)
73-
if self.tcp_ports:
74-
self._setup_tcp_protocol_routing()
59+
# TODO: uncomment
60+
# def update_gateway_routes(self, router: http.Router[http.RouteHandler]):
61+
# """
62+
# Override to set up only TCP routing without HTTP proxy.
63+
#
64+
# ParadeDB uses the native PostgreSQL wire protocol (not HTTP), so we
65+
# only need TCP protocol routing - not HTTP proxying. Adding an HTTP
66+
# proxy without a host restriction would cause all HTTP requests to be
67+
# forwarded to the PostgreSQL container, breaking other services.
68+
# """
69+
# # Start the container
70+
# self.start_container()
71+
#
72+
# # Set up only TCP protocol routing (skip HTTP proxy from base class)
73+
# if self.tcp_ports:
74+
# self._setup_tcp_protocol_routing()
7575

7676
def tcp_connection_matcher(self, data: bytes) -> bool:
7777
"""

paradedb/tests/test_extension.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,14 +167,18 @@ def test_mixed_tcp_and_http_traffic():
167167
)
168168

169169
caller_identity = sts_client.get_caller_identity()
170-
assert "Account" in caller_identity, "STS HTTP API should work alongside ParadeDB TCP"
170+
assert "Account" in caller_identity, (
171+
"STS HTTP API should work alongside ParadeDB TCP"
172+
)
171173
assert "Arn" in caller_identity, "STS should return valid caller identity"
172174

173175
# Finally, verify ParadeDB still works after HTTP requests
174176
conn = get_connection()
175177
cursor = conn.cursor()
176178
cursor.execute("SELECT 'tcp_works_after_http' as verification;")
177179
result = cursor.fetchone()
178-
assert result[0] == "tcp_works_after_http", "ParadeDB should still work after HTTP requests"
180+
assert result[0] == "tcp_works_after_http", (
181+
"ParadeDB should still work after HTTP requests"
182+
)
179183
cursor.close()
180184
conn.close()

0 commit comments

Comments
 (0)