simplify insights query test to avoid indexing flakiness

Focus on verifying the proxy forwards StartQuery and GetQueryResults
correctly rather than waiting for actual query results. The query ID
format and matching status between proxy and direct AWS calls proves
the operations are being proxied.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: whummer

aws-proxy/tests/proxy/test_cloudwatch.py

@@ -539,9 +539,11 @@ def test_logs_readonly_insights_query(start_aws_proxy, cleanups):
     StartQuery and GetQueryResults are read operations for CloudWatch Logs Insights
     but don't match standard prefixes. This test verifies they're correctly
     forwarded when read_only: true is configured.
+
+    Note: This test verifies the proxy correctly forwards these operations, not that
+    CloudWatch Logs Insights returns results (which can be flaky due to indexing delays).
     """
     log_group_name = f"/test/readonly-insights/{short_uid()}"
-    log_stream_name = f"stream-{short_uid()}"
 
     # start proxy - forwarding requests for CloudWatch Logs in read-only mode
     config = ProxyConfig(
@@ -558,58 +560,43 @@ def test_logs_readonly_insights_query(start_aws_proxy, cleanups):
     logs_client = connect_to().logs
     logs_client_aws = boto3.client("logs")
 
-    # create log group and stream in AWS
+    # create log group in AWS
     logs_client_aws.create_log_group(logGroupName=log_group_name)
     cleanups.append(
         lambda: logs_client_aws.delete_log_group(logGroupName=log_group_name)
     )
 
-    logs_client_aws.create_log_stream(
-        logGroupName=log_group_name, logStreamName=log_stream_name
-    )
+    # start_query through local client (proxied) - should work in read-only mode
+    # The fact that we get a valid query ID proves the request was proxied to AWS
+    start_time = int((time.time() - 300) * 1000)  # 5 minutes ago
+    end_time = int((time.time() + 60) * 1000)  # 1 minute from now
 
-    # put log events
-    timestamp = int(time.time() * 1000)
-    logs_client_aws.put_log_events(
+    query_response = logs_client.start_query(
         logGroupName=log_group_name,
-        logStreamName=log_stream_name,
-        logEvents=[
-            {"timestamp": timestamp, "message": "Test log message for insights query"},
-        ],
-    )
-
-    # start_query and get_query_results through local client (proxied)
-    # Retry the entire query cycle if it completes with no results (events not indexed yet)
-    def _run_insights_query():
-        start_time = int((time.time() - 300) * 1000)  # 5 minutes ago
-        end_time = int((time.time() + 60) * 1000)  # 1 minute from now
-
-        # start_query - should work in read-only mode
-        query_response = logs_client.start_query(
-            logGroupName=log_group_name,
-            startTime=start_time,
-            endTime=end_time,
-            queryString="fields @timestamp, @message | limit 10",
-        )
-        query_id = query_response["queryId"]
-
-        # poll get_query_results until complete
-        for _ in range(30):
-            results = logs_client.get_query_results(queryId=query_id)
-            if results["status"] in ["Complete", "Failed", "Cancelled"]:
-                break
-            time.sleep(1)
-
-        if results["status"] != "Complete":
-            raise AssertionError(f"Query failed with status: {results['status']}")
-        if len(results["results"]) < 1:
-            # Query completed but no results - events may not be indexed yet, retry
-            raise AssertionError("Query completed but no results found yet")
-        return results
-
-    results = retry(_run_insights_query, retries=10, sleep=5)
-    assert results["status"] == "Complete"
-    assert len(results["results"]) >= 1
+        startTime=start_time,
+        endTime=end_time,
+        queryString="fields @timestamp, @message | limit 10",
+    )
+    query_id = query_response["queryId"]
+    assert query_id is not None
+    # AWS query IDs are UUIDs, verify format to confirm this came from AWS
+    assert len(query_id) == 36 and query_id.count("-") == 4
+
+    # get_query_results through local client (proxied) - should work in read-only mode
+    # The fact that we get a valid status proves the request was proxied to AWS
+    results = logs_client.get_query_results(queryId=query_id)
+    assert "status" in results
+    assert results["status"] in [
+        "Scheduled",
+        "Running",
+        "Complete",
+        "Failed",
+        "Cancelled",
+    ]
+
+    # Verify via AWS client that the query exists (same query ID)
+    results_aws = logs_client_aws.get_query_results(queryId=query_id)
+    assert results_aws["status"] == results["status"]
 
 
 def test_logs_resource_name_matching(start_aws_proxy, cleanups):