minor renaming for better API consistency

Author: whummer

paradedb/localstack_paradedb/extension.py

@@ -83,9 +83,9 @@ def tcp_connection_matcher(self, data: bytes) -> bool:
 
         return False
 
-    def should_proxy_request(self, headers: Headers) -> bool:
+    def http2_request_matcher(self, headers: Headers) -> bool:
         """
-        Define whether a request should be proxied based on request headers.
+        Define whether an HTTP2 request should be proxied based on request headers.
         Not used for TCP connections - see tcp_connection_matcher instead.
         """
         return False

typedb/localstack_typedb/extension.py

@@ -37,7 +37,7 @@ def __init__(self):
             http2_ports=http2_ports,
         )
 
-    def should_proxy_request(self, headers: Headers) -> bool:
+    def http2_request_matcher(self, headers: Headers) -> bool:
         # determine if this is a gRPC request targeting TypeDB
         content_type = headers.get("content-type") or ""
         req_path = headers.get(":path") or ""

utils/localstack_extensions/utils/docker.py

@@ -124,7 +124,7 @@ def update_gateway_routes(self, router: http.Router[http.RouteHandler]):
         # apply patches to serve HTTP/2 requests
         for port in self.http2_ports or []:
             apply_http2_patches_for_grpc_support(
-                self.container_host, port, self.should_proxy_request
+                self.container_host, port, self.http2_request_matcher
             )
 
         # set up raw TCP proxies with protocol detection
@@ -174,8 +174,8 @@ def _setup_tcp_protocol_routing(self):
         )
 
     @abstractmethod
-    def should_proxy_request(self, headers: Headers) -> bool:
-        """Define whether a request should be proxied, based on request headers."""
+    def http2_request_matcher(self, headers: Headers) -> bool:
+        """Define whether an HTTP2 request should be proxied, based on request headers."""
 
     def on_platform_shutdown(self):
         self._remove_container()

utils/localstack_extensions/utils/h2_proxy.py

@@ -64,7 +64,7 @@ def close(self):
 
 
 def apply_http2_patches_for_grpc_support(
-    target_host: str, target_port: int, should_proxy_request: ProxyRequestMatcher
+    target_host: str, target_port: int, http2_request_matcher: ProxyRequestMatcher
 ):
     """
     Apply some patches to proxy incoming gRPC requests and forward them to a target port.
@@ -123,7 +123,7 @@ def received_from_http2_client(self, data, default_handler: Callable):
                         buffered_data = b"".join(self.buffer)
                         self.buffer = []
 
-                        if should_proxy_request(headers):
+                        if http2_request_matcher(headers):
                             self.state = ForwardingState.FORWARDING
                             self.backend.send(buffered_data)
                         else:

utils/tests/integration/conftest.py

@@ -55,7 +55,7 @@ def _tcp_health_check():
             health_check_fn=_tcp_health_check,
         )
 
-    def should_proxy_request(self, headers: Headers) -> bool:
+    def http2_request_matcher(self, headers: Headers) -> bool:
         """
         gRPC services use direct TCP connections, not HTTP gateway routing.
         This method is not used in these tests but is required by the base class.

utils/tests/integration/test_extension_integration.py

@@ -42,8 +42,8 @@ def test_extension_implements_required_methods(self, grpcbin_extension):
         """Test that the extension properly implements the required abstract methods."""
         from werkzeug.datastructures import Headers
 
-        # should_proxy_request should be callable
-        result = grpcbin_extension.should_proxy_request(Headers())
+        # http2_request_matcher should be callable
+        result = grpcbin_extension.http2_request_matcher(Headers())
         assert result is False, "gRPC services should not proxy through HTTP gateway"
 
     def test_multiple_ports_configured(self, grpcbin_extension):

utils/tests/unit/test_tcp_protocol_detector.py

@@ -113,7 +113,7 @@ def tcp_connection_matcher(self, data: bytes) -> bool:
                 matcher = create_signature_matcher(b"\xde\xad\xbe\xef", offset=4)
                 return matcher(data)
 
-            def should_proxy_request(self, headers: Headers) -> bool:
+            def http2_request_matcher(self, headers: Headers) -> bool:
                 return False
 
         extension = CustomProtocolExtension()
@@ -145,7 +145,7 @@ def tcp_connection_matcher(self, data: bytes) -> bool:
                 variant2 = create_prefix_matcher(b"V2:")
                 return combine_matchers(variant1, variant2)(data)
 
-            def should_proxy_request(self, headers: Headers) -> bool:
+            def http2_request_matcher(self, headers: Headers) -> bool:
                 return False
 
         extension = MultiProtocolExtension()
@@ -172,7 +172,7 @@ def tcp_connection_matcher(self, data: bytes) -> bool:
                 # Inline custom logic without helper functions
                 return len(data) >= 8 and data.startswith(b"MAGIC") and data[7] == 0x42
 
-            def should_proxy_request(self, headers: Headers) -> bool:
+            def http2_request_matcher(self, headers: Headers) -> bool:
                 return False
 
         extension = InlineMatcherExtension()